Fix PHPStan error with is_subclass_of

bmitch · Jul 6, 2022 · fca4871 · fca4871
1 parent 7185468
commit fca4871
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -4,9 +4,9 @@ parameters:
     - %currentWorkingDirectory%/src/
 
   checkGenericClassInNonGenericObjectType: false
+  reportUnmatchedIgnoredErrors: true
   ignoreErrors:
     - '/Construct empty\(\) is not allowed\. Use more strict comparison/'
-    - '/Call to function is_subclass_of\(\) with class-string and class-string will always evaluate to true/'
     - '/Casting to .+ something that''s already/'
 
   symfony:

diff --git a/src/Event/HookLoader.php b/src/Event/HookLoader.php
@@ -20,7 +20,10 @@ final class HookLoader
 {
     /**
      * @var array<string, string>
-     * @psalm-var array<class-string<\Churn\Event\Subscriber\HookDecorator>, class-string>
+     * @psalm-var array<
+     * class-string<\Churn\Event\Subscriber\HookDecorator>,
+     * class-string<AfterAnalysisHook>|class-string<AfterFileAnalysisHook>|class-string<BeforeAnalysisHook>
+     * >
      */
     private $decorators;
 

diff --git a/tests/Integration/Command/RunCommandTest.php b/tests/Integration/Command/RunCommandTest.php
@@ -205,6 +205,7 @@ public function it_can_use_a_hook_by_path(): void
     public function it_throws_for_invalid_hooks(): void
     {
         $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid hook: invalid-hook');
         $this->commandTester->execute([
             'paths' => [__FILE__, __DIR__ . '/AssessComplexityCommandTest.php'],
             '-c' => __DIR__ . '/config/hook-invalid.yml',