frontend: disable wifi-updater and let user know if wifi service is disabled #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
disabled_wifi
branch
from
58de4ca to
4a7b826
Compare
| @@ -21,6 +21,9 @@ RUN_AS_REGULAR_USER="sudo -u blueos" | |||
| # Set BlueOS log folder | |||
| BLUEOS_LOG_FOLDER_PATH="/var/logs/blueos" | |||
|
|
|||
| # Replace spaces with commas in the disabled services list | |||
| BLUEOS_DISABLE_SERVICES=${BLUEOS_DISABLE_SERVICES// /,} | |||
There was a problem hiding this comment.
why the replace is necessary here ? the list should be comma separated already
There was a problem hiding this comment.
because some people (@JoaoMario109 ) may be used to type the list with spaces after commas 🤷
this is just a very basic sanitization
patrickelectric
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it clear to the user when the service got disabled. Also points into the direction to enable it.
More than that, it stops trying to make a bunch of requests (wifi-updater) when the service is not even running.