frontend: Change Create/Edit extension card top differ from Create and Editing operations #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change to differ editing extension and creating new extension
* Change to not send empty {} on user_permissions to backend
* Change component based if it's creating or editing * Allow for empty string or valid json in user_permissions since users just want to use original ones most of time
JoaoMario109
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
patrickelectric
approved these changes
Jul 22, 2024
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing:
When creating:
Also allow custom permissions to be either empty or valid json, since sometimes when user does not wants to use custom permissions they can only send empty