Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT[BMQIO]: remove UT designed with a race condition #500

Merged

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Nov 5, 2024

This test is designed with a thread race, so we are removing it:

[2024-11-04T21:39:45.781Z] 04NOV2024_21:39:11.821 92542:139652027287296 TRACE /blazingmq/src/groups/bmq/bmqio/bmqio_ntcchannel.cpp:540 BMQIO.NTCCHANNEL NTC channel 0x000000027cad30 at 127.0.0.1:50102 to 127.0.0.1:37048 connection complete: [ type = COMPLETE context = [ endpoint = 127.0.0.1:37048 name = localhost:37048 latency = (0, 1670645) source = SYSTEM ] ] 

[2024-11-04T21:39:45.781Z] 04NOV2024_21:39:11.821 92542:139652027287296 TRACE /blazingmq/src/groups/bmq/bmqio/bmqio_ntcchannelfactory.cpp:143 BMQIO.NTCCHANNELFACTORY NTC factory event CHANNEL_UP status [ Category = SUCCESS ] 

[2024-11-04T21:39:45.781Z] 04NOV2024_21:39:11.821 92542:139652027287296 TRACE /blazingmq/src/groups/bmq/bmqio/bmqio_ntcchannel.cpp:1524 BMQIO.NTCCHANNEL NTC listener 0x000000027bbec0 at 127.0.0.1:37048 closed: [ Category = CANCELED ] 

[2024-11-04T21:39:45.781Z] 04NOV2024_21:39:11.821 92542:139652027287296 TRACE /blazingmq/src/groups/bmq/bmqio/bmqio_ntcchannelfactory.cpp:120 BMQIO.NTCCHANNELFACTORY NTC listener 0x000000027bbec0 at 127.0.0.1:37048 deregistered 

[2024-11-04T21:39:45.781Z] Error /blazingmq/src/groups/bmq/bmqio/bmqio_ntcchannelfactory.t.cpp(928): 1159    (failed)

@678098 678098 marked this pull request as ready for review November 5, 2024 18:02
@678098 678098 requested a review from a team as a code owner November 5, 2024 18:02
@678098 678098 requested a review from hallfox November 5, 2024 18:04
@678098 678098 merged commit 46bea6d into bloomberg:main Nov 5, 2024
16 of 17 checks passed
@678098 678098 deleted the 241105_rm_ntcchannel_UT_race_condition branch November 5, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants