-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add job to build API documentation on push to main
#490
CI: Add job to build API documentation on push to main
#490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 343 of commit 54a5e8c has completed with FAILURE
54a5e8c
to
2738f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge it, but also I have a concern about 3rd party actions having write access to the repo commits.
2738f1d
to
7d142cb
Compare
.github/workflows/documentation.yaml
Outdated
cd docs/ | ||
git config --global user.name "${{ github.actor }}" | ||
git config --global user.email "${{ github.actor }}@users.noreply.github.com" | ||
git commit -am "Update C++ API docs from commit ${{ github.sha }} on main" | ||
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://stackoverflow.com/a/58393457 I am not sure whether this will kick off a new build immediately. We may need an personal access token for that.
@678098 Can be squash-merged if it's good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pniedzielski looks good, the only thing is DCO check I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 345 of commit 7d142cb has completed with FAILURE
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Patrick M. Niedzielski <[email protected]>
a3f8c03
to
ef07941
Compare
oops, meant to squash... oh well. |
This PR adds a job that runs on pushes to the
main
branch and on manual workflows to regenerate documentation frommain
, and push it to thegh-pages
branch.In the future we'll want to:
These will be future PRs. This PR is just aimed at getting our website in shape.
Please review this patch carefully. I have run the commands I expect to happen manually in a shell, but if my understanding of the canned GitHub Actions is incorrect, this action may fail in new and fun ways after merge, and I don't believe there is an effective way to test beforehand.