Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add job to build API documentation on push to main #490

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

pniedzielski
Copy link
Collaborator

@pniedzielski pniedzielski commented Oct 30, 2024

This PR adds a job that runs on pushes to the main branch and on manual workflows to regenerate documentation from main, and push it to the gh-pages branch.

In the future we'll want to:

  1. Run a similar job on versioned releases.
  2. Teach cmake to use Doxygen (this is a bit more involved than it should be, because of our BDE-ish cmake), and use cmake to build.
  3. Warn about Doxygen errors on PRs.

These will be future PRs. This PR is just aimed at getting our website in shape.

Please review this patch carefully. I have run the commands I expect to happen manually in a shell, but if my understanding of the canned GitHub Actions is incorrect, this action may fail in new and fun ways after merge, and I don't believe there is an effective way to test beforehand.

@pniedzielski pniedzielski requested a review from a team as a code owner October 30, 2024 16:39
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 343 of commit 54a5e8c has completed with FAILURE

678098
678098 previously approved these changes Oct 30, 2024
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge it, but also I have a concern about 3rd party actions having write access to the repo commits.

.github/workflows/documentation.yaml Outdated Show resolved Hide resolved
Comment on lines 49 to 53
cd docs/
git config --global user.name "${{ github.actor }}"
git config --global user.email "${{ github.actor }}@users.noreply.github.com"
git commit -am "Update C++ API docs from commit ${{ github.sha }} on main"
git push
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://stackoverflow.com/a/58393457 I am not sure whether this will kick off a new build immediately. We may need an personal access token for that.

@pniedzielski pniedzielski requested a review from 678098 October 30, 2024 18:57
@pniedzielski
Copy link
Collaborator Author

@678098 Can be squash-merged if it's good.

Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pniedzielski looks good, the only thing is DCO check I think

.github/workflows/documentation.yaml Outdated Show resolved Hide resolved
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 345 of commit 7d142cb has completed with FAILURE

pniedzielski and others added 3 commits October 30, 2024 21:55
Signed-off-by: Patrick M. Niedzielski <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]>
Signed-off-by: Patrick M. Niedzielski <[email protected]>
@pniedzielski pniedzielski force-pushed the generate-doxygen-on-main branch from a3f8c03 to ef07941 Compare October 30, 2024 21:55
@pniedzielski pniedzielski requested a review from 678098 October 30, 2024 21:55
@pniedzielski pniedzielski merged commit f10d75f into bloomberg:main Oct 30, 2024
17 checks passed
@pniedzielski
Copy link
Collaborator Author

oops, meant to squash... oh well.

@pniedzielski pniedzielski deleted the generate-doxygen-on-main branch January 8, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants