-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix[MQB]: add log for response message #487
Fix[MQB]: add log for response message #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good; let's add an integration test to make sure.
Behavior before:
Behavior after:
It's verbose and so we may revisit this, but for the moment this is great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small change and typo fix, but great job! Could you squash these commits into one once you've fixed these, force push, and I'll merge.
5332348
to
8c85392
Compare
Signed-off-by: Emelia Lei <[email protected]>
8c85392
to
a95bedc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Log the responses in
AdminSession::finalizeAdminCommand()
to make it easier to read the response.