Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[BMQ]: Fix leaking internal headers in bmqa_mocksession #485

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

hallfox
Copy link
Collaborator

@hallfox hallfox commented Oct 29, 2024

Also fixes an incorrect change that marked bmqt as a private package

@hallfox hallfox requested a review from a team as a code owner October 29, 2024 15:38
Also fixes an incorrect change that marked bmqt as a private package

Signed-off-by: Taylor Foxhall <[email protected]>
@hallfox hallfox changed the title [BMQ]: Fix leaking internal headers in bmqa_mocksession Fix[BMQ]: Fix leaking internal headers in bmqa_mocksession Oct 29, 2024
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

src/groups/bmq/CMakeLists.txt Show resolved Hide resolved
@hallfox hallfox merged commit 044fd8c into bloomberg:main Oct 29, 2024
30 of 31 checks passed
@hallfox hallfox deleted the fix-header-leak branch October 29, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants