Perf[MQB]: throttle logs critical for broadcast #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Malygin <[email protected]>
678098
commented
Oct 28, 2024
| << "pending PUSH messages"; | ||
| BALL_LOG_DEBUG << d_state_p->uri() << ": " | ||
| << "no more timer scheduled to check expiration of " | ||
| << "pending PUSH messages"; |
There was a problem hiding this comment.
The same severity as a few lines above
dorjesinpo
reviewed
Oct 28, 2024
| << bmqt::AckResult::toAscii(ackResult); | ||
| if (d_throttledCachedPutMessages.requestPermission()) { | ||
| BALL_LOG_INFO << d_state_p->uri() << ": erased window of " | ||
| << numErased << " (" << d_expiredPutNum |
There was a problem hiding this comment.
d_expiredPutNum is more like "total erased broadcast PUTs". But what is the meaning of this counter; why do we need it?
There was a problem hiding this comment.
If we are throttling logs, we still might want to know how many of these we skipped. Might be useful for debug, but also I'm okay to remove it.
| << " cached broadcasted PUTs upon " | ||
| << bmqt::AckResult::toAscii(ackResult); | ||
| if (d_throttledCachedPutMessages.requestPermission()) { | ||
| BALL_LOG_INFO << d_state_p->uri() << ": erased window of " |
There was a problem hiding this comment.
This could very well be BALL_LOG_DEBUG. This log does not have much importance.
There was a problem hiding this comment.
Will redo it to debug then and remove the counter. Let's keep it simple.
Signed-off-by: Evgeny Malygin <[email protected]>
|
@dorjesinpo simplified the changes |
dorjesinpo
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging every 500 cached PUTs expiration not only generates gigabytes of logs, but also potentially limits broadcast speed.