Fix[MWC]: ntc channel execute after close #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
force-pushed
the
t2530_ntcchannel_thread_safety
branch
4 times, most recently
from
b834872 to
f89e093
Compare
678098
commented
Oct 17, 2024
| @@ -356,7 +356,8 @@ class NtcChannel : public mwcio::Channel, | |||
| /// this channel for the write to succeed. | |||
| void write(Status* status, | |||
| const bdlbb::Blob& blob, | |||
| bsls::Types::Int64 watermark) BSLS_KEYWORD_OVERRIDE; | |||
| bsls::Types::Int64 watermark = bsl::numeric_limits<int>::max()) | |||
| BSLS_KEYWORD_OVERRIDE; | |||
There was a problem hiding this comment.
blazingmq/src/groups/mwc/mwcio/mwcio_channel.h
Lines 178 to 181 in 50018e7
The interface has default for warermark
678098
commented
Oct 17, 2024
| @@ -371,7 +372,7 @@ class NtcChannel : public mwcio::Channel, | |||
| /// Shutdown this channel, and cancel all pending read requests (but do | |||
| /// not invoke them). Pass the specified `status` to any registered | |||
| /// `CloseFn`s. | |||
| void close(const Status& status) BSLS_KEYWORD_OVERRIDE; | |||
| void close(const Status& status = Status()) BSLS_KEYWORD_OVERRIDE; | |||
There was a problem hiding this comment.
The interface has default for status
678098
force-pushed
the
t2530_ntcchannel_thread_safety
branch
2 times, most recently
from
201cc9f to
5a319c8
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Signed-off-by: Evgeny Malygin <[email protected]>
678098
force-pushed
the
t2530_ntcchannel_thread_safety
branch
from
5a319c8 to
2d89761
Compare
hallfox
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to call
NtcChannel::executeafterNtcChannel::close.closefreesd_streamSocket_sp, andexecutedidn't check for validity of this field and just dereferences it.