Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max number of Apps is now 1048575 #405

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Max number of Apps is now 1048575 #405

merged 2 commits into from
Sep 11, 2024

Conversation

dorjesinpo
Copy link
Collaborator

Currently, BMQ support 4096 Apps. This needs to go up to support Reliable Broadcast

@dorjesinpo dorjesinpo requested a review from a team as a code owner August 23, 2024 20:56
@dorjesinpo dorjesinpo added the enhancement New feature or request label Aug 23, 2024
@dorjesinpo dorjesinpo requested a review from kaikulimu August 23, 2024 21:32
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 177 of commit 8702c64 has completed with FAILURE

Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
src/groups/mqb/mqbs/mqbs_filestoreprotocol.h Outdated Show resolved Hide resolved
@kaikulimu
Copy link
Collaborator

@dorjesinpo Back to you

Signed-off-by: dorjesinpo <[email protected]>
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 238 of commit c82850a has completed with FAILURE

@dorjesinpo dorjesinpo assigned kaikulimu and unassigned dorjesinpo Sep 4, 2024
Copy link
Collaborator

@kaikulimu kaikulimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dorjesinpo dorjesinpo merged commit 538776c into main Sep 11, 2024
36 checks passed
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
* Max number of Apps is now 1048575

Signed-off-by: dorjesinpo <[email protected]>

* addressing review

Signed-off-by: dorjesinpo <[email protected]>

---------

Signed-off-by: dorjesinpo <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
* Max number of Apps is now 1048575

Signed-off-by: dorjesinpo <[email protected]>

* addressing review

Signed-off-by: dorjesinpo <[email protected]>

---------

Signed-off-by: dorjesinpo <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
* Max number of Apps is now 1048575

Signed-off-by: dorjesinpo <[email protected]>

* addressing review

Signed-off-by: dorjesinpo <[email protected]>

---------

Signed-off-by: dorjesinpo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants