Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqba_domainmanager: refactor code into locateOrCreateDomain function #368

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

lukedigiovanna
Copy link
Contributor

Refactor code to locate or create a domain into a single function for reusability.

This is particularly useful for #352.

@lukedigiovanna lukedigiovanna requested a review from a team as a code owner July 22, 2024 20:59
678098
678098 previously approved these changes Jul 23, 2024
src/groups/mqb/mqba/mqba_domainmanager.h Outdated Show resolved Hide resolved
Co-authored-by: Evgeny Malygin <[email protected]>
Signed-off-by: Luke DiGiovanna <[email protected]>
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@678098 678098 merged commit 76081a7 into bloomberg:main Jul 23, 2024
29 checks passed
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants