Add autoIncremented parameter to batch-post in bmqtool #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syuzvinsky
force-pushed
the
auto-inc-field
branch
2 times, most recently
from
2b067ba to
e7bfc4f
Compare
A new parameter 'autoIncremented' can be provided to 'batch-post' command in bmqtool. It can be used to test subscriptions with expressions like 'x % 3 == 0' where "x" is a value of 'autoIncremented' field, so, every 3rd element will be received by the subscriber. Signed-off-by: Stanislav Yuzvinsky <[email protected]>
syuzvinsky
force-pushed
the
auto-inc-field
branch
from
e7bfc4f to
b750e98
Compare
678098
requested changes
Jul 22, 2024
| @@ -268,6 +268,10 @@ class Parameters { | |||
|
|
|||
| bsl::vector<Subscription> d_subscriptions; | |||
|
|
|||
| bsl::string d_autoIncrementedField; | |||
| // A name of a property to put auto-incremented values | |||
| // in batch-posting mode. | |||
There was a problem hiding this comment.
Let's use Doxygen style comment, /// and before the variable
There was a problem hiding this comment.
The style is derived from the style used for all private variables in this file. Applying doxygen style for just one field looks impractical.
| @@ -95,6 +95,10 @@ class PostingContext { | |||
| bmqa::MessageProperties d_properties; | |||
| // Properties that will be added to a posted message | |||
|
|
|||
| unsigned int d_autoIncrementedValue; | |||
| // A value that will be auto-incremented and added to | |||
| // the message properties. | |||
There was a problem hiding this comment.
Might convert to Doxygen style comment
There was a problem hiding this comment.
the same comment about style uniformity
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Stanislav Yuzvinsky <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Stanislav Yuzvinsky <[email protected]>
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Stanislav Yuzvinsky <[email protected]>
678098
reviewed
Jul 22, 2024
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Stanislav Yuzvinsky <[email protected]>
678098
reviewed
Jul 22, 2024
Co-authored-by: Evgeny Malygin <[email protected]> Signed-off-by: Stanislav Yuzvinsky <[email protected]>
Signed-off-by: Stanislav Yuzvinsky <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
A new parameter 'autoIncremented' can be provided to 'batch-post' command in bmqtool. It can be used to test subscriptions with expressions like 'x % 3 == 0' where "x" is a value of 'autoIncremented' field, so, every 3rd element will be received by the subscriber. Signed-off-by: Stanislav Yuzvinsky <[email protected]> Co-authored-by: Evgeny Malygin <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
A new parameter 'autoIncremented' can be provided to 'batch-post' command in bmqtool. It can be used to test subscriptions with expressions like 'x % 3 == 0' where "x" is a value of 'autoIncremented' field, so, every 3rd element will be received by the subscriber. Signed-off-by: Stanislav Yuzvinsky <[email protected]> Co-authored-by: Evgeny Malygin <[email protected]>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
A new parameter 'autoIncremented' can be provided to 'batch-post' command in bmqtool. It can be used to test subscriptions with expressions like 'x % 3 == 0' where "x" is a value of 'autoIncremented' field, so, every 3rd element will be received by the subscriber. Signed-off-by: Stanislav Yuzvinsky <[email protected]> Co-authored-by: Evgeny Malygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new parameter 'autoIncremented' can be provided to 'batch-post' command in bmqtool.
It can be used to test subscriptions with expressions like 'x % 3 == 0' where "x" is a value of 'autoIncremented' field, so, every 3rd element will be received by the subscriber.