Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: build and run C++ UTs in a separate step #343

Merged
merged 1 commit into from
Jul 1, 2024
Merged

CI: build and run C++ UTs in a separate step #343

merged 1 commit into from
Jul 1, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jun 28, 2024 •
edited
Loading

CI:

  • Fix incorrect path to file causing hash evaluation error.
  • Pin ntf-core version in build-deps.sh to prevent hash collisions causing ntf-core rebuild even on cache hit.
  • Extract UTs build from the main broker build step, to speed up the CI. Some later steps are depend only on the broker/tool, so it's not necessary to wait for all UTs to link and run to launch these tests

Future work: extract packages install and project configuration to reusable workflow and reference it instead of copy-pasting the same.

@678098 678098 requested a review from a team as a code owner June 28, 2024 12:57
@678098 678098 force-pushed the 240628_split_UT_build branch 4 times, most recently from 9cc3012 to 222a90c Compare June 28, 2024 16:32
@678098 678098 force-pushed the 240628_split_UT_build branch from 222a90c to 3843c02 Compare June 28, 2024 16:40
@678098 678098 changed the title [WIP]CI: build and run C++ UTs in a separate step CI: build and run C++ UTs in a separate step Jun 28, 2024
@678098 678098 requested a review from pniedzielski June 28, 2024 17:58
@678098 678098 force-pushed the 240628_split_UT_build branch from 75863f8 to 3843c02 Compare June 28, 2024 18:17
pniedzielski
pniedzielski approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and future work also looks like a good direction.

@678098 678098 merged commit 2c85044 into bloomberg:main Jul 1, 2024
24 checks passed
@678098 678098 deleted the 240628_split_UT_build branch July 1, 2024 19:24
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
CI: build and run C++ UTs in a separate step (bloomberg#343)
b2b8ada 
Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
CI: build and run C++ UTs in a separate step (bloomberg#343)
a0a4ed4 
Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
CI: build and run C++ UTs in a separate step (bloomberg#343)
b4af58d 
Signed-off-by: Evgeny Malygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pniedzielski pniedzielski pniedzielski approved these changes

Assignees

@pniedzielski pniedzielski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @pniedzielski