Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial compiler warnings #339

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fix trivial compiler warnings #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edc5a5a
Fix trivial compiler warnings
chrisbeard Jun 26, 2024
6e0a33a
Fix FileManagerImpl class name comment header
chrisbeard Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/applications/bmqstoragetool/m_bmqstoragetool_filemanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void closeLedger(mqbsl::Ledger* ledger)
} // close unnamed namespace

// =====================
// class FileManagerReal
// class FileManagerImpl
// =====================

// CREATORS
Expand Down Expand Up @@ -220,7 +220,7 @@ QueueMap FileManagerImpl::buildQueueMap(const bsl::string& cslFile,
}

// ==================================
// class FileManagerReal::FileHandler
// class FileManagerImpl::FileHandler
// ==================================

template <typename ITER>
Expand Down
2 changes: 0 additions & 2 deletions src/applications/bmqtool/m_bmqtool_interactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ namespace m_bmqtool {

namespace {

const char k_LOG_CATEGORY[] = "APPLICATION";

/// Print to stdout the specified `message` prefixed by the specified
/// `prefix`.
void printMessage(bsl::ostream& out, int index, const bmqa::Message& message)
Expand Down
2 changes: 1 addition & 1 deletion src/groups/bmq/bmqp/bmqp_compression.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,4 @@ struct Compression_Impl {
} // close package namespace
} // close enterprise namespace

#endif
#endif
4 changes: 0 additions & 4 deletions src/groups/mqb/mqbblp/mqbblp_clustercatalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
namespace BloombergLP {
namespace mqbblp {

namespace {
const char k_LOG_CATEGORY[] = "MQBBLP.CLUSTERCATALOG";
} // close unnamed namespace

// --------------------
// class ClusterCatalog
// --------------------
Expand Down
2 changes: 1 addition & 1 deletion src/groups/mqb/mqbc/mqbc_partitionfsmobserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,4 @@ class PartitionFSMObserver {
} // close package namespace
} // close enterprise namespace

#endif
#endif
11 changes: 4 additions & 7 deletions src/groups/mwc/mwctsk/mwctsk_logcontroller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,10 @@ void printCategoryWithDelimiter(const bsl::shared_ptr<bsl::ostream>& os,
*os << "\n";
}

static void
bslsLogHandler(BSLS_ANNOTATION_UNUSED bsls::LogSeverity::Enum severity,
const char* file,
int line,
const char* message)
static void bslsLogHandler(bsls::LogSeverity::Enum severity,
const char* file,
int line,
const char* message)
{
// Custom message handler for bsls::Log. Redirect the specified
// 'message', the specified 'file' and the specified 'line' to
Expand Down Expand Up @@ -122,8 +121,6 @@ LogControllerConfig::balToBslsLogLevel(ball::Severity::Level level)
case ball::Severity::e_TRACE: return bsls::LogSeverity::e_TRACE;
default: return bsls::LogSeverity::e_ERROR;
};

return bsls::LogSeverity::e_ERROR;
}

LogControllerConfig::CategoryProperties::CategoryProperties(
Expand Down
Loading