Updates and fixes in slow file checking #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#30791) Before, we would just throw 500 if a user passes an attachment that is not an allowed type. This commit catches this error and throws a 422 instead since this should be considered a validation error.
This commit forces the resource owner (user) to always approve OAuth 2.0 authorization requests if the client is public (e.g. native applications). As detailed in [RFC 6749 Section 10.2](https://www.rfc-editor.org/rfc/rfc6749.html#section-10.2), > The authorization server SHOULD NOT process repeated authorization requests automatically (without active resource owner interaction) without authenticating the client or relying on other measures to ensure that the repeated request comes from the original client and not an impersonator. With the implementation prior to this patch, attackers with access to the redirect URI (e.g., the loopback interface for `git-credential-oauth`) can get access to the user account without any user interaction if they can redirect the user to the `/login/oauth/authorize` endpoint somehow (e.g., with `xdg-open` on Linux). Fixes go-gitea#25061. Co-authored-by: wxiaoguang <[email protected]>
Just merge actions.go file to action.go Signed-off-by: Bo-Yi Wu <[email protected]>
Since there is now a second `<input>` in the repo buttons, we can make a better-looking layout with no empty space, except on mobile. Also I fixed one bug with focus border on clone panel. ## Large <img width="1163" alt="Screenshot 2024-04-23 at 22 25 22" src="https://github.com/go-gitea/gitea/assets/115237/8135a572-aa67-4672-ad49-b76b06890b52"> ## Medium <img width="870" alt="Screenshot 2024-04-23 at 22 25 34" src="https://github.com/go-gitea/gitea/assets/115237/9e93f61c-3315-4a78-8328-8cefad5b50fa"> ## Mobile <img width="416" alt="Screenshot 2024-04-23 at 22 25 52" src="https://github.com/go-gitea/gitea/assets/115237/859e341f-807a-48e6-8bcf-31715963216c">
go-gitea#30831) Fixes: go-gitea#30816, regression from go-gitea#30723. Fixes: go-gitea#30815, regression from go-gitea#30723. Fomantic [expects a callback](https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L530-L534) to be called during `hide` which we did not do, so it could never remove the margin it added to `body`. I do observe the body content shifting to right by 1px when modal opens, but this is a bug that existed on v1.21 as well, so not a regression. --------- Co-authored-by: wxiaoguang <[email protected]>
Fix this error seen on PR page, regression from go-gitea#30803: Co-authored-by: wxiaoguang <[email protected]>
…#30814) Fix go-gitea#30807 reuse functions in services
…o-gitea#30817) We should be listing all repositories by default. Fixes go-gitea#28483.
Reduce the context line number to 1, make "git grep" search respect the include/exclude patter, and fix go-gitea#30785
fix typo for the Docker README
Fix go-gitea#29514 There are too many usage of `NewRequestWithValues`, so there's no need to check all of them. Just one is enough I think.
1. "enter" doesn't work (I think it is the last enter support for go-gitea#14843) 2. if a branch name contains something like `&`, then the branch selector doesn't update
Before this patch, we were using `Date` getter/setter methods that worked with local time to get a list of Sundays that are in the range of some start date and end date. The problem with this was that the Sundays are in Unix epoch time and when we changed the "startDate" argument that was passed to make sure it is on a Sunday, this change would be reflected when we convert it to Unix epoch time. More specifically, I observed that we may get different Unix epochs depending on your timezone when the returned list should rather be timezone-agnostic. This led to issues in US timezones that caused the contributor, code frequency, and recent commit charts to not show any chart data. This fix resolves this by using getter/setter methods that work with UTC since it isn't dependent on timezones. Fixes go-gitea#30851. --------- Co-authored-by: Sam Fisher <[email protected]>
Fix the space between the box and label for checkboxes, and fix incorrect usages in "repo-issue.js"
Follow go-gitea#30345 Follow go-gitea#30547 `ellipsis` / `white-space` shouldn't be put on the general dropdown components.
…0784) instead of: - zowner/gcode - awesome/nul - zowner/nul - zowner/zzz we will get: - awesome/nul - zowner/gcode - zowner/nul - zowner/zzz
Otherwise there would be more similar issues like go-gitea#29287
The actions artifacts should be able to be migrate to the new storage place.
…ok and add a transaction (go-gitea#30805) Merging PR may fail because of various problems. The pull request may have a dirty state because there is no transaction when merging a pull request. ref go-gitea#25741 (comment) This PR moves all database update operations to post-receive handler for merging a pull request and having a database transaction. That means if database operations fail, then the git merging will fail, the git client will get a fail result. There are already many tests for pull request merging, so we don't need to add a new one. --------- Co-authored-by: wxiaoguang <[email protected]>
Fix go-gitea#30883 Fix go-gitea#29591 --------- Co-authored-by: KN4CK3R <[email protected]>
Hello! After contributing for some time I am interested in taking a more involved role as a maintainer. When time allows it, I plan to perform code reviews, continue resolving/triaging issues, and engage with the community to see if I can offer any useful insights. My current interests are in backend work, but I plan to study the web frontend architecture to see if I can contribute there as well. Thanks for this awesome project. I hope I can both learn and contribute to its continued success! PR list: https://github.com/go-gitea/gitea/pulls?q=is%3Apr+is%3Aclosed+author%3Akemzeb Discord: kemzeb
This workaround is not neccessary any more since monaco 0.35.0. Ref: microsoft/monaco-editor#2962 Ref: microsoft/vscode#173688
# The problem The previous implementation will start multiple POST requests from the frontend when moving a column and another bug is moving the default column will never be remembered in fact. # What's changed - [x] This PR will allow the default column to move to a non-first position - [x] And it also uses one request instead of multiple requests when moving the columns - [x] Use a star instead of a pin as the icon for setting the default column action - [x] Inserted new column will be append to the end - [x] Fix go-gitea#30701 the newly added issue will be append to the end of the default column - [x] Fix when deleting a column, all issues in it will be displayed from UI but database records exist. - [x] Add a limitation for columns in a project to 20. So the sorting will not be overflow because it's int8. --------- Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Tested Subscribe, Follow, Star, Watch, and System Status. --------- Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: silverwind <[email protected]>
To improve maintainability
Almost works like GitHub * use Tab/Shift-Tab to indent/unindent the selected lines * use Enter to insert a new line with the same indentation and prefix
1. Remove tickgit badge, the service [only gives errors](https://www.tickgit.com/browse?repo=github.com/go-gitea/gitea&branch=main) and the repo [seems unmaintained](https://github.com/augmentable-dev/tickgit). 2. Color the gitpod badge green because grey badges look odd.
See https://docs.docker.com/reference/build-checks/legacy-key-value-format/. Fixes these warnings seen during the docker build: ``` 4 warnings found (use --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 5) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 75) - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 76) ``` Introduced in: moby/buildkit#4923
This change fixes cases when a Wiki page refers to a video stored in the Wiki repository using relative path. It follows the similar case which has been already implemented for images. Test plan: - Create repository and Wiki page - Clone the Wiki repository - Add video to it, say `video.mp4` - Modify the markdown file to refer to the video using `<video src="video.mp4">` - Commit the Wiki page - Observe that the video is properly displayed --------- Co-authored-by: wxiaoguang <[email protected]>
And remove some jQuery functions
Related to go-gitea#23461, and help some cases like go-gitea#31412 For developers, they could use browser's Performance tool to collect performance data, while this PR is also quite handy to optimize the `index.js`. For end users, this PR is simple enough and could figure out the slow function quickly. 
…go-gitea#31447) Fix go-gitea#29065 Remove status filtering from GetUIDsAndNotificationCounts sql. --------- Co-authored-by: kiatt210 <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Given an empty issue/PR comment, the comment history would not be updated if the user were to submit it. Therefore, it would make since to just disable the comment button when the text editor is empty. This is inline with what GitHub does when given empty text editor input. --------- Co-authored-by: wxiaoguang <[email protected]>
Caused by go-gitea#31091 --------- Co-authored-by: silverwind <[email protected]>
The overflow menu button was incorrectly included in the measurement of the width of the items. As a result, it could get stuck in a loop alternating between different measurements as the button appears and disappears.
Uses the correct string for searching - this is what it looks like prior to the change:  (observe how the top box has "Search teams" even though collaborator would be user
This PR enhances the labels handling in issue_search by optimizing the SQL query and de-duplicate the IDs when generating the query string. --------- Co-authored-by: techknowlogick <[email protected]>
Refactor the legacy code and remove some jQuery calls.
* Use dropzone to handle file uploading for all cases, including pasting and dragging * Merge duplicate code, use consistent behavior for link generating Close go-gitea#20130 --------- Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
make preventDuplicates default to true, users get a clear UI feedback and know that "a new message appears". Fixes: go-gitea#26651 --------- Co-authored-by: silverwind <[email protected]>
Close go-gitea#31502 Related to go-gitea#31419. In this PR, the avatar width is set to 3em, but the height is not set, so the image is not squared. When object-fit is set to contain, it can't maintain the radius of the image. Result: 
Running update-index --remove for every individual file is slow, so remove them all together. When such a commit lands in the main branch, it can then cause PR creation and patch checking for all open PRs to be slow, or time out entirely. In our case, a commit that removes 1383 files causes the 60 seconds timeout to be reached. With this change checking takes about a second. The git.AddObjectToIndex case most likely needs the same optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains new upstream changes and a fix for slow patch checking with commits that contains many file additions or deletions.
See: https://projects.blender.org/infrastructure/blender-projects-platform/issues/91