bgfx::init with ID3D11Device as context will Release but not AddRef

[bghgary]

I am passing in an ID3D11Device pointer to bgfx::init to use an existing device. It appears bgfx will take this pointer as is but yet it will release the pointer on shutdown. This seems asymmetrical. Is this on purpose for some reason? Why not AddRef and Release or not Release?

[bkaradzic]

Why not AddRef and Release or not Release?

Yeah, it should AddRef to it.

[bkaradzic]

Can you try changing code here:

bgfx/src/renderer_d3d11.cpp

Line 886 in 3b9b2aa

if (NULL == m_device)

To this:

			if (NULL != m_device)
			{
				m_device->AddRef();
				m_device->GetImmediateContext(&m_deviceCtx);

				if (NULL == m_deviceCtx)
				{
					BX_TRACE("Init error: Unable to retrieve Direct3D11 ImmediateContext.");
					goto error;
				}

				m_featureLevel = m_device->GetFeatureLevel();
			}
			else

[bghgary]

I can try tomorrow. I'm a bit worried changing this will break someone and they won't know it since it will just leak. How many people use this feature?

[bkaradzic]

Not many. I used it at one point for Maya plugin, and Maya never complained about refcount. They might assumed that device might be destroyed and AddRef before passing pointer to user. Anyhow behavior you noticed is incorrect, and it shouldn't destroy device or require user to AddRef manually.

[bghgary]

I've add a single line to AddRef the device and that seems to work for my scenario. I will send a PR soon.

[bkaradzic]

Fixed here: 66de825

I also wanted to move that else block above since it's shorter and it's more readable that way.

[bghgary]

Great! Thanks.