Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vagrant tests and resolve userxattr #106

Merged
merged 47 commits into from
Jul 11, 2023
Merged

Add Vagrant tests and resolve userxattr #106

merged 47 commits into from
Jul 11, 2023

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jul 7, 2023 •
edited
Loading

Closes #82

@ezrizhu ezrizhu self-assigned this Jul 7, 2023
@ezrizhu ezrizhu marked this pull request as ready for review July 7, 2023 19:49
@ezrizhu ezrizhu requested review from angelhof and mgree July 7, 2023 19:49
angelhof
angelhof approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@angelhof angelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's merge after @mgree reviews

Vagrantfile Outdated Show resolved Hide resolved
mgree
mgree requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny tweak. Looks great!

.github/workflows/vagrant.yaml Outdated Show resolved Hide resolved
.github/workflows/vagrant.yaml Outdated Show resolved Hide resolved
@ezrizhu ezrizhu merged commit 0f98176 into main Jul 11, 2023
@ezrizhu ezrizhu deleted the vagrant branch July 11, 2023 17:07
@mgree mgree mentioned this pull request Jul 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree mgree requested changes

@angelhof angelhof angelhof approved these changes

Assignees

@ezrizhu ezrizhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM tests on Github Actions
3 participants
@ezrizhu @mgree @angelhof