Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shasta extension for libbash #5
Shasta extension for libbash #5
Changes from 19 commits
46b8ebf
1037f11
e9bc760
73dadf9
8355528
3617f0b
55446d4
bd2690d
c48c376
59303c2
95ea75c
6167577
3eae7db
bc3d55b
93660aa
3eb8fe6
d64fde1
cd751b2
070e805
a8c3441
1afbeb8
fbf8d51
dcf1e32
ea94fec
93ee4dd
01db807
1a1d50c
7beed18
650d818
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am scared of this dependency because I am afraid of dependency hell (either due to circular dependencies or because a downstream program (like PaSh) might want a different version of one and the other).
I guess we don't have this issue with libdash because we use a JSON object? Could we do sth similar here (maybe in a different PR?)? Alternatively, is my fear irrational and we just have to bite the bullet and do it? I am wondering whether someone could use shasta without needing to import libbash and whatever that includes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your intuition — although I can’t think of an obvious scenario that would cause a problem. The code right now doesn’t actually import anything from libbash (in a runtime capacity) except a handful of enums, so I can easily remove the dependency after copying those over (± some minor changes).