Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoxide under Bincode in the Wild #525

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Add zoxide under Bincode in the Wild #525

merged 1 commit into from
Mar 15, 2022

Conversation

ajeetdsouza
Copy link
Contributor

Hey, zoxide seems to be a different use of Bincode from the ones mentioned in the README, so I thought you might like to include it here.

Since it's a shell plugin, I decided to optimize for performance as much as possible. zoxide has to store a rather small database, so Bincode becomes a really good choice -- at that size, it's significantly faster than SQLite as well as a couple of other binary formats I tested against.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #525 (175bea8) into trunk (3d50bab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #525   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files          47       47           
  Lines        3178     3178           
=======================================
  Hits         2259     2259           
  Misses        919      919           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d50bab...175bea8. Read the comment docs.

Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tried porting zoxide to bincode 2.0.0-rc, but I ran into some issues with the #[serde(borrow)] flag you use for Vec<Dir>. This will require some internal rewrites, but expect a PR on that soon.

Thanks for letting us know!

@VictorKoenders VictorKoenders merged commit 7ef6fe2 into bincode-org:trunk Mar 15, 2022
@ajeetdsouza
Copy link
Contributor Author

That sounds great, thank you!

@ajeetdsouza ajeetdsouza deleted the patch-1 branch March 15, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants