-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate 4 #1667
Merged
Merged
Release candidate 4 #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The obsolete properties `TextBrush` and `SeparatorsBrush` were removed from the `CoreAxis` class. These properties had been previously marked as obsolete and renamed to `LabelsPaint` and `SeparatorsPaint`, respectively. The removal of these properties helps to clean up the codebase by eliminating deprecated code.
Removed MaxOuterRadius property and replaced it with OuterRadiusOffset across the codebase: - Updated `1.6.paint tasks.md` to remove `MaxOuterRadius` from `PieSeries<int>` initialization. - Modified `Hello.razor` to replace `MaxOuterRadius` with `OuterRadiusOffset` in `PieChart.Series` initialization. - Removed `MaxOuterRadius` property and its methods from `CorePieSeries.cs`. - Updated `IPieSeries.cs` to remove `MaxOuterRadius` from the interface definition.
Added comments indicating that the PathGeometry class is obsolete but still in use within the HeatPathShape class. Included a ToDo comment suggesting an update to use the AreaGeometry class instead. Added a pragma directive to disable compiler warning CS0612 for the obsolete PathGeometry.
Renamed `GaugeBuilder` to `GaugeGenerator` in documentation and added links to gauge samples. Removed detailed code examples and `IGaugeBuilder` interface. Deleted `GaugeBuilder.cs` file, replacing its functionality with `GaugeGenerator.BuildSolidGauge`.
Updated `citiesSeries` in `series.md` to use a new mapping function that returns `Coordinate` objects with the `index` as the X coordinate and `city.Population` as the Y coordinate. Removed obsolete properties (`PrimaryValue`, `SecondaryValue`, `TertiaryValue`, `QuaternaryValue`, and `QuinaryValue`) from `ChartPoint.cs` to enforce the use of the `Coordinate` property.
Reformatted `using` directives for better readability. Removed obsolete `Index` property from `ChartPointContext` class. Users should now use `ChartPoint.Index` instead.
The documentation for tooltip point text has been updated to include the `ToolTipLabelFormatter` property in addition to the existing `YToolTipLabelFormatter` and `XToolTipLabelFormatter` properties. This change clarifies that users can now use any of these three properties to define the text displayed in tooltips for a given point, providing more flexibility in customizing tooltip content.
Refactored namespaces in IPieSeries.cs by removing `using System;` and adding `using LiveChartsCore.Drawing;` and `using LiveChartsCore.Measure;`. Updated Series.cs by removing obsolete `DataPointerHover` and `DataPointerHoverLost` events, replacing them with `ChartPointPointerHover` and `ChartPointPointerHoverLost`. Adjusted `OnPointerEnter` and `OnPointerLeft` methods to reflect these changes.
The LegendShapeSize property has been removed from the Series<TModel, TVisual, TLabel, TDrawingContext> class. This property was previously used to get or set the size of the legend shape and was replaced by the MiniatureShapeSize property.
The entire MIT license header, using directives for System and LiveChartsCore.Drawing, namespace declaration LiveChartsCore.SkiaSharpView.Painting, and the obsolete PaintTask class have been removed from PaintTask.cs. This effectively clears the file of all its previous content.
The `TappedCommand` property has been removed from the `CartesianChart`, `PieChart`, and `PolarChart` classes. This property was marked as obsolete and has been replaced by the `PressedCommand` and `ReleasedCommand` properties. The `PointerMoveCommand` property has been removed from the `CartesianChart`, `PieChart`, and `PolarChart` classes. This property was marked as obsolete and has been replaced by the `MovedCommand` property. These changes clean up the codebase by removing deprecated properties that were previously marked with `[Obsolete]` attributes.
The entire content of the `LegendBindingContext.cs` file has been removed. This includes the MIT license header, all using directives, and the complete `LegendBindingContext` class definition. The class contained properties for series, font family, font size, font weight, font style, text brush, and background.
Updated ChangingPaintTasks.cs to use SKCartesianChart instead of the obsolete TestCartesianChartView. Removed TestCartesianChartView.cs as it is no longer needed.
Lets remove these sets, the theme should set those properties for us.
Know AngualrTicks, Labels and needle Needle are themed instead of hard-coded.
Update themes
Removed code that swapped `min` and `max` values if `min` was greater than `max`, along with related comments. Retained check for `min` and `max` being `double.MaxValue` or `double.MinValue`, setting defaults if true.
Inverted axes
Corrected the MinLimit and MaxLimit values in the AxisTesting class for the x2 and y2 axes. Previously, MaxLimit was set to 0 and MinLimit was set to 10, which was incorrect. The values have been swapped so that MinLimit is now 0 and MaxLimit is now 10, while keeping the IsInverted property set to true.
LiveCharts is compatible with SkiaSharp 3 and Skiasharp 2, but we can not upgrade the target to 3.0 because that would beak avalonia as it is not compatible yet, and it does not use the views provided by skiashap.
Updated target frameworks in LiveChartsCore.SkiaSharpView.Uno.WinUI.csproj and LiveChartsCore.SkiaSharpView.WinUI.csproj to include net6.0-windows10.0.19041.0. This ensures compatibility with both .NET 6.0 and .NET 8.0 on Windows 10 version 19041.0, enhancing project flexibility and compatibility. The EnableMsixTooling property remains enabled, and the TargetPlatformMinVersion is unchanged.
Expanded comments in `LiveChartsCore.SkiaSharpView.WPF.csproj` and `LiveChartsCore.SkiaSharpView.WinForms.csproj` to include a note about SkiaSharp 3.x removing `netcoreapp3.1` target and questioning whether to upgrade to SkiaSharp 3.x. No changes to `TargetFrameworks` property itself.
Updated the LiveChartsCore.SkiaSharpView.Xamarin.Forms.csproj file to downgrade the SkiaSharp.Views.Forms package from version 3.0.0-preview.4.1 to 2.88.8. This change addresses potential compatibility or stability issues with the newer version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.