Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Stale bot by action #2347

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

McGiverGim
Copy link
Member

The stale bot is not working reliable.

This replaces the old stale bot by the new that uses a github action.

Two different things about the old bot:

  • This executes daily at 4:30 (configurable). The old I think executed once at hour. I don't know if we want to do the same.
  • This new bot has not the equivalent to exemptMilestones: true so we need to manually add the Pinned tag if needed.

Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, first of all stale bot has started working again, so there is not so much pressure any more on getting this changed.
Secondly, one difference is that stale bot is configured to exclude pull requests with a Milestone associated from becoming stale: exemptMilestones: true. Can we do this with this action as well?

@McGiverGim
Copy link
Member Author

As I said in my message the is not an equivalent command for this. There are several requests in the original repo, so maybe en un future...

@mikeller
Copy link
Member

Sorry, I had overlooked this. Since stale bot is working again for now I'd opt to stay with it for now, and see if there will be a fully featured action based replacement in the future - using Milestones to 'pin' pull requests to a certain release is convenient.

@McGiverGim
Copy link
Member Author

It's ok for me. I will check the action bot from time to time to see if finally it gets implemented.

@McGiverGim
Copy link
Member Author

One thing more: the stale bot seems not reliable again. We have several PR that must be closed and they are not, for example: #2224

@mikeller
Copy link
Member

@McGiverGim:

One thing more: the stale bot seems not reliable again.

😿

Ok. But if we are switching to the Action I'd propose that we also add a label 'Has Milestone' to exempt-pr-labels:, in order to make it immediately obvious if a pull request has been genuinely pinned, or is only exempt because it has a Milestone.

@McGiverGim
Copy link
Member Author

I will update it to add this new label, but my comment was only to let you know, maybe is there a way to fix the old stale bot.

@mikeller
Copy link
Member

mikeller commented Jan 5, 2021

@McGiverGim: I don't think there is much we can do to fix stale bot - this is offered by a third party and run on their resources. And I suspect that they probably have little incentive to fix / improve it, as GitHub itself seems to be positioning Actions as the way forward for things like this. So updating this pull request and then going ahead with it is probably the best option that we have.

@McGiverGim McGiverGim force-pushed the move_stale_to_action branch from 68c7627 to e63d406 Compare January 7, 2021 07:59
@McGiverGim
Copy link
Member Author

McGiverGim commented Jan 7, 2021

Added the Has Milestone tag to the issues and pr exempt label (I think we can use it in both).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mikeller mikeller merged commit 4449e39 into betaflight:master Jan 7, 2021
@McGiverGim
Copy link
Member Author

This PR is closed, but only to not forgot, it seems that it now accepts some kind of exempt milestones:
image

And a PR is in progress to exempt all milestones: actions/stale#291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants