-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Stale bot by action #2347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, first of all stale bot has started working again, so there is not so much pressure any more on getting this changed.
Secondly, one difference is that stale bot is configured to exclude pull requests with a Milestone associated from becoming stale: exemptMilestones: true
. Can we do this with this action as well?
As I said in my message the is not an equivalent command for this. There are several requests in the original repo, so maybe en un future... |
Sorry, I had overlooked this. Since stale bot is working again for now I'd opt to stay with it for now, and see if there will be a fully featured action based replacement in the future - using Milestones to 'pin' pull requests to a certain release is convenient. |
It's ok for me. I will check the action bot from time to time to see if finally it gets implemented. |
One thing more: the stale bot seems not reliable again. We have several PR that must be closed and they are not, for example: #2224 |
😿 Ok. But if we are switching to the Action I'd propose that we also add a label 'Has Milestone' to |
I will update it to add this new label, but my comment was only to let you know, maybe is there a way to fix the old stale bot. |
@McGiverGim: I don't think there is much we can do to fix stale bot - this is offered by a third party and run on their resources. And I suspect that they probably have little incentive to fix / improve it, as GitHub itself seems to be positioning Actions as the way forward for things like this. So updating this pull request and then going ahead with it is probably the best option that we have. |
68c7627
to
e63d406
Compare
Added the |
Kudos, SonarCloud Quality Gate passed! |
This PR is closed, but only to not forgot, it seems that it now accepts some kind of exempt milestones: And a PR is in progress to exempt all milestones: actions/stale#291 |
The stale bot is not working reliable.
This replaces the old stale bot by the new that uses a github action.
Two different things about the old bot:
exemptMilestones: true
so we need to manually add thePinned
tag if needed.