Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support jekyll 4 and change Ruby version for travisci #59

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Support jekyll 4 and change Ruby version for travisci #59

merged 2 commits into from
Oct 23, 2019

Conversation

leleabhinav
Copy link
Contributor

@leleabhinav leleabhinav commented Oct 10, 2019 •
edited
Loading

This PR add minor changes required for this gem to work when Gemfile has jekyll > 4.0

@welcome
Copy link

welcome bot commented Oct 10, 2019

Welcome! Congrats on your first pull request to Jekyll Titles From Headings. If you haven't already, please be sure to check out the contributing guidelines.

@request-info
Copy link

request-info bot commented Oct 10, 2019

Thanks for this. Do you mind providing a bit more information about what problem you're trying to solve?

@leleabhinav leleabhinav marked this pull request as ready for review October 10, 2019 02:03
@leleabhinav
Copy link
Contributor Author

@benbalter Can you please take a look on this PR, I am making changes similar to what were done in #59

@kylekirkby
Copy link

Hey @benbalter,

Would you kindly assist in getting this PR merged?

Best regards,

Kyle

@benbalter benbalter merged commit 546dd89 into benbalter:master Oct 23, 2019
@welcome
Copy link

welcome bot commented Oct 23, 2019

Congrats on getting your first pull request to Jekyll Titles From Headings merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉

If you're interested in tackling another bug or feature, take a look at the open issues, especially those labeled help wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
more-information-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leleabhinav @kylekirkby @benbalter