Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase Extension Convention #992

Open
borkaehw opened this issue Feb 7, 2020 · 1 comment
Open

Phase Extension Convention #992

borkaehw opened this issue Feb 7, 2020 · 1 comment

Comments

@borkaehw
Copy link
Contributor

borkaehw commented Feb 7, 2020

Once we start writing more custom phase extensions to the repository, we need to set up a convention to follow. Rules like

  • The name of phase .bzl file (e.g. phase_scalafmt.bzl)
  • The name of extension .bzl file (e.g. phase_scalafmt_ext.bzl)
  • The object names in extension file
    • Extension object (e.g. ext_scalafmt)
    • Rule to provide ScalaRulePhase (e.g. scalafmt_singleton)

Once we have agreements, I am happy to write it to a README.

@ittaiz
Copy link
Member

ittaiz commented Feb 8, 2020

I agree.
Sounds to me like #965 needs to be defined first, no? If so we should advance (hopefully next week) it and then indeed agree on this

gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants