Improve new scheduled entry command #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a project where I would like to use journal style headlines outside a journal file. This small adjustment enables the option to insert journal style headlines at point. I thought it might be useful sometimes for other user too. If you think the extra command is too "exclusive" to be added by default then it is no problem if you remove it. But then it would still be nice to keep the optional `insert-at-point` argument.
dalanicolai
force-pushed
the
improve-new-scheduled-entry-command
branch
from
3fccdb1 to
ccbf09d
Compare
Currently the command inserts the time preceding the TODO. This PR implements fixes (non-desctructively), but it assumes that bastibe#335 and bastibe#337 get merged first.
dalanicolai
force-pushed
the
improve-new-scheduled-entry-command
branch
from
ccbf09d to
412328e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
org-journal-new-scheduled-entry, the time is inserted before the TODO. However, org requires a TODO to be placed at the beginning of a headline. This PR fixes this non-destructively, but it assumes that #335 and #337 get merged first.Besides for consistency, these changes are welcome because they make the journal entries work nicely with the org-wild-notifier package.