Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update call to NewProcessCollector #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivierbeytrison
Copy link

While trying to build the code, got the following error :

./exporter.go:140:68: too many arguments in call to prometheus.NewProcessCollector
        have (int, string)
        want (prometheus.ProcessCollectorOpts)

Fixed by using the default struct

wmfgerrit pushed a commit to wikimedia/operations-docker-images-production-images that referenced this pull request Dec 13, 2023
The original repo hasn't been updated in 9 months and contains a bug
breaking the build (see
bakins/php-fpm-exporter#48)

Use a fixed fork (https://github.com/olivierbeytrison/php-fpm-exporter)

Upgrade image to bullseye, build image to golang1.15

Change-Id: Ic22672202b9a573a3d12323f220d0554168e7bb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant