Skip to content

Commit

Permalink
Rename "scrape_failures" to "scrape_failures_total"
Browse files Browse the repository at this point in the history
This metric expresses a sum / accumulating unit, and should thusly be
suffixed with total[1]

https://prometheus.io/docs/practices/naming/#metric-names
  • Loading branch information
andrewhowdencom committed Jul 26, 2017
1 parent 7154bf4 commit c67d95d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (e *Exporter) newCollector() *collector {
maxActiveProcesses: newFuncMetric("active_max_processes", "Maximum active process count"),
maxChildrenReached: newFuncMetric("max_children_reached_total", "Number of times the process limit has been reached"),
slowRequests: newFuncMetric("slow_requests_total", "Number of requests that exceed request_slowlog_timeout"),
scrapeFailures: newFuncMetric("scrape_failures", "Number of errors while scraping php_fpm"),
scrapeFailures: newFuncMetric("scrape_failures_total", "Number of errors while scraping php_fpm"),
}
}

Expand Down

0 comments on commit c67d95d

Please sign in to comment.