staking: verifying staker's signature over slashing tx #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
force-pushed
the
btc-del-verify-sig
branch
from
65e7eb6 to
958826b
Compare
gusin13
reviewed
Sep 6, 2024
| keys.sort_by(|a, b| { | ||
| let a_serialized = a.serialize(); | ||
| let b_serialized = b.serialize(); | ||
| let a_serialized = a.to_bytes(); |
There was a problem hiding this comment.
whats difference in serialize and to_bytes?
There was a problem hiding this comment.
Well k256's VerifyingKey does not have serialize() function but instead defines to_bytes()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7
This PR adds verifications on staker's signature over the slashing tx in BTC delegation requests. This includes:
handle_btc_delegation(the version withfull-validationfeature)datagento use 1st FP's secret key for generating pub rand commit and finality sig