Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AmazonEC2ContainerServiceAutoscaleRole creation #33

Merged
merged 2 commits into from
Jun 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ module "container_service_cluster" {
- `container_instance_security_group_id` - Security group ID of the EC2 container instances
- `container_instance_ecs_for_ec2_service_role_name` - Name of IAM role associated with EC2 container instances
- `ecs_service_role_name` - Name of IAM role for use with ECS services
- `ecs_autoscale_role_name` - Name of IAM role for use with ECS service autoscaling
- `ecs_service_role_arn` - ARN of IAM role for use with ECS services
- `ecs_autoscale_role_arn` - ARN of IAM role for use with ECS service autoscaling
- `container_instance_ecs_for_ec2_service_role_arn` - ARN of IAM role associated with EC2 container instances
- `container_instance_autoscaling_group_name` - Name of container instance Autoscaling Group
10 changes: 0 additions & 10 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,6 @@ data "aws_iam_policy_document" "ecs_autoscale_assume_role" {
}
}

resource "aws_iam_role" "ecs_autoscale_role" {
name = "ecs${title(var.environment)}AutoscaleRole"
assume_role_policy = "${data.aws_iam_policy_document.ecs_autoscale_assume_role.json}"
}

resource "aws_iam_role_policy_attachment" "ecs_service_autoscaling_role" {
role = "${aws_iam_role.ecs_autoscale_role.name}"
policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceAutoscaleRole"
}

#
# Security group resources
#
Expand Down
8 changes: 0 additions & 8 deletions outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ output "ecs_service_role_name" {
value = "${aws_iam_role.ecs_service_role.name}"
}

output "ecs_autoscale_role_name" {
value = "${aws_iam_role.ecs_autoscale_role.name}"
}

output "container_instance_autoscaling_group_name" {
value = "${aws_autoscaling_group.container_instance.name}"
}
Expand All @@ -30,10 +26,6 @@ output "ecs_service_role_arn" {
value = "${aws_iam_role.ecs_service_role.arn}"
}

output "ecs_autoscale_role_arn" {
value = "${aws_iam_role.ecs_autoscale_role.arn}"
}

output "container_instance_ecs_for_ec2_service_role_arn" {
value = "${aws_iam_role.container_instance_ec2.arn}"
}