chore: improve the dashboard comment query #5016
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouho
reviewed
Jan 10, 2025
| title: 'No review (external) last 14 days' | ||
| issue_query: 'repo:aws/s2n-tls is:open is:pr review:none -label:status/stale -label:s2n-core created:>{{ date("-14 days") }}' | ||
| title: 'No comment (external) last 14 days' | ||
| issue_query: 'repo:aws/s2n-tls is:open is:pr comments:0 -label:status/stale -label:s2n-core created:>{{ date("-14 days") }}' |
There was a problem hiding this comment.
Is it possible to filter by "0 comments from the team member"? Minor edge case, but we could miss a stale PR if the requester themselves leave a comment, which could happen.
There was a problem hiding this comment.
While the query language allows for -commenter:dougch to toss out anything I have commented on, to do this for the whole team isn't really feasible. Yes, there is a change of missing some, but the noise of "0 reviews" when we've already commented is a bigger frustration.
There was a problem hiding this comment.
Got it. Yeah it's definitely nicer than getting a bunch of false negatives. Just wanted to call it out
jouho
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Our original GitHub dashboard has a "No review" block that should actually be PRs that have no comment, update the query.
Call-outs:
The distinction between review and comment is a bit pedantic.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? tested using the GitHub Query https://github.com/search?q=repo%3Aaws%2Fs2n-tls+is%3Aopen+is%3Apr+comments%3A0+-label%3Astatus%2Fstale+-label%3As2n-core&type=pullrequests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.