Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directory name models/apis/guardduty conflict #1753

Closed
hori-ryota opened this issue Jan 26, 2018 · 2 comments · Fixed by #1754
Closed

directory name models/apis/guardduty conflict #1753

hori-ryota opened this issue Jan 26, 2018 · 2 comments · Fixed by #1754
Labels
bug This issue is a bug.

Comments

@hori-ryota
Copy link
Contributor

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

AWS SDK: master(Merge pull request #1752 from aws/release · aws/aws-sdk-go@febbdf7)

Version of Go (go version)?

What issue did you see?

$ git checkout .
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   models/apis/GuardDuty/2017-11-28/api-2.json
        modified:   models/apis/GuardDuty/2017-11-28/docs-2.json

I think this behavior caused by renaming dir models/apis/GuardDuty/ to models/apis/guardduty/

Steps to reproduce

pull master

git version: 2.15.1

If you have have an runnable example, please include it.
hori-ryota pushed a commit to hori-ryota/aws-sdk-go that referenced this issue Jan 26, 2018
Fix conflict of dirname GuardDuty to guardduty. fix aws#1753
05e510b
@hori-ryota hori-ryota mentioned this issue Jan 26, 2018
Merged
@xibz xibz added the bug This issue is a bug. label Jan 26, 2018
@xibz xibz mentioned this issue Jan 26, 2018
Closed
xibz pushed a commit that referenced this issue Jan 26, 2018
@hori-ryota @xibz
Fix conflict of dirname GuardDuty to guardduty. fix #1753 (#1754)
3d45f5e
@awstools awstools mentioned this issue Jan 26, 2018
Merged
@xibz
Copy link
Contributor

xibz commented Jan 26, 2018

@hori-ryota - We just release a new version of the SDK, v1.12.69, and deprecating v1.12.68. Please let us know if you are having anymore issues.

AlekSi added a commit to percona/pmm-managed that referenced this issue Jan 26, 2018
@AlekSi
Re-add AWS SDK to resolve problem with v1.12.68.
f6752dc 
aws/aws-sdk-go#1753
aws/aws-sdk-go#1754
aws/aws-sdk-go#1756
@xibz xibz mentioned this issue Jan 26, 2018
Merged
@xibz
Copy link
Contributor

xibz commented Jan 26, 2018

@hori-ryota - With PR #1758 will help catch future collisions. :)

jasdel pushed a commit that referenced this issue Feb 5, 2018
@xibz @jasdel
adds validation to ensure there is no duplication of services in mode…
f9f8469 
…ls/apis (#1758)

This change prevents service teams from releasing multiple apis under different names. This has caused dep and builds to fail for some due to insensitive casing and folder naming collisions on specific OS builds.
#1753
#1755
xibz added a commit to xibz/aws-sdk-go that referenced this issue Feb 15, 2018
@xibz
adds validation to ensure there is no duplication of services in mode…
f76b349 
…ls/apis (aws#1758)

This change prevents service teams from releasing multiple apis under different names. This has caused dep and builds to fail for some due to insensitive casing and folder naming collisions on specific OS builds.
aws#1753
aws#1755
askomorokhov pushed a commit to percona/pmm-managed that referenced this issue Mar 22, 2021
@AlekSi
Re-add AWS SDK to resolve problem with v1.12.68.
37e0fdd 
aws/aws-sdk-go#1753
aws/aws-sdk-go#1754
aws/aws-sdk-go#1756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conflict of dirname GuardDuty to guardduty. fix #1753 hori-ryota/aws-sdk-go
2 participants
@xibz @hori-ryota