-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-dotnet): Add .NET Lambda support #27979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Hi @vlesierse, thanks for opening this PR. We're still debating this a bit internally but wanted to provide some update for you: We're most likely going to figure out a way to help you release this as a self-published module. It's not that we don't want it, but we don't think it belongs in the aws-cdk repo, since it is not strictly an L2.
Good question -- we allowed those modules into the main cdk repo when we were still experimenting with what made sense to be included and what didn't. Looking back, we probably wish we had pulled them out into separate repositories, but they must continue to be included for legacy reasons. If we ever release a new major version of CDK, we'd likely move these modules out on their own. So -- nothing actionable yet, but I didn't want to keep you hanging. In the meantime, I notice the build is failing, which is something that would need fixing anyways :) Cheers. |
Thank you for your transparency and providing an update and considerations the team is currently working with. Happy work on continuing bringing this feature to CDK in whatever form. Obviously giving .NET the same treatment as Go & Python at the moment is my preference... |
@kaizencc on the note of the failing build, it currently fails in the install phase in CodeBuild with Update |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Hi @vlesierse, we are prepared to go forward with you on a separate cdklabs repository for lambda-dotnet. I've created it here: https://github.com/cdklabs/awscdk-lambda-dotnet. Feel free to create a PR on that repo (it might need some maintenance work that I'm doing right now) and/or contact me on cdk.dev if you need additional support. |
@kaizencc that this greatly appreciated. I'll finished some cleanup, additional documentation and tests in a PR to the repository. Thank you! |
Sounds great! I'm gonna close this PR since it's not going to get merged in to cdk proper, and see you on the cdklabs repo. @vlesierse note that the cdklabs repo is governed by projen so all project configuration goes into the |
Adds support .NET Lambda functions as described in the issue #23236 and RFC Issue aws/aws-cdk-rfcs/issues/469. This feature is introduced as new alpha package
@aws-cdk/aws-lambda-dotnet-alpha
Closes #23236.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license