Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(region-info): move the AWS_CDK_METADATA set to its own file #27887

Merged
merged 1 commit into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions packages/aws-cdk-lib/region-info/build-tools/fact-tables.ts
Original file line number Diff line number Diff line change
@@ -1,41 +1,4 @@
/* eslint-disable @aws-cdk/no-literal-partition */
export const AWS_CDK_METADATA = new Set([
'af-south-1',
'ap-east-1',
'ap-northeast-1',
'ap-northeast-2',
// 'ap-northeast-3',
'ap-south-1',
// 'ap-south-2',
'ap-southeast-1',
'ap-southeast-2',
// 'ap-southeast-3',
// 'ap-southeast-4',
'ca-central-1',
'cn-north-1',
'cn-northwest-1',
'eu-central-1',
// 'eu-central-2',
'eu-north-1',
'eu-south-1',
// 'eu-south-2',
'eu-west-1',
'eu-west-2',
'eu-west-3',
// 'il-central-1',
// 'me-central-1',
'me-south-1',
'sa-east-1',
'us-east-1',
'us-east-2',
// 'us-gov-east-1',
// 'us-gov-west-1',
// 'us-iso-east-1',
// 'us-isob-east-1',
'us-west-1',
'us-west-2',
]);

/**
* The hosted zone Id if using an alias record in Route53.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as path from 'path';
import * as fs from 'fs-extra';
import {
APPMESH_ECR_ACCOUNTS,
AWS_CDK_METADATA,
CLOUDWATCH_LAMBDA_INSIGHTS_ARNS,
DLC_REPOSITORY_ACCOUNTS,
ELBV2_ACCOUNTS,
Expand All @@ -14,6 +13,7 @@ import {
PARAMS_AND_SECRETS_LAMBDA_LAYER_ARNS,
APPCONFIG_LAMBDA_LAYER_ARNS,
} from './fact-tables';
import { AWS_CDK_METADATA } from './metadata';
import {
AWS_REGIONS,
AWS_SERVICES,
Expand Down
33 changes: 33 additions & 0 deletions packages/aws-cdk-lib/region-info/build-tools/metadata.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/*
* Do not edit this file manually. To prevent misconfiguration, this file
* should only be modified by an automated GitHub workflow, that ensures
* that the regions present in this list correspond to all the regions
* where we have the AWS::CDK::Metadata handler deployed.
*
* See: https://github.com/aws/aws-cdk/issues/27189
*/

export const AWS_CDK_METADATA = new Set([
'af-south-1',
'ap-east-1',
'ap-northeast-1',
'ap-northeast-2',
'ap-south-1',
'ap-southeast-1',
'ap-southeast-2',
'ca-central-1',
'cn-north-1',
'cn-northwest-1',
'eu-central-1',
'eu-north-1',
'eu-south-1',
'eu-west-1',
'eu-west-2',
'eu-west-3',
'me-south-1',
'sa-east-1',
'us-east-1',
'us-east-2',
'us-west-1',
'us-west-2',
]);
Loading