Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken link in README.md #27877

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

blackcat1383
Copy link
Contributor

@blackcat1383 blackcat1383 commented Nov 7, 2023

The link to nodejs.org is broken.

From: https://nodejs.org/en/about/releases
image

To: https://nodejs.org/en/about/previous-releases
image

Please let me know if the download page is a better fit for this...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 7, 2023 17:47
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 7, 2023
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! That link looks like the right one.

Copy link
Contributor

mergify bot commented Nov 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 782bac4 into aws:main Nov 7, 2023
28 of 29 checks passed
@blackcat1383 blackcat1383 deleted the chore-fix-broken-link-readme branch November 7, 2023 18:15
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1b8b879
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Nov 7, 2023
Following up on #27877, we had a broken link in two places. This fixes the second.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mikewrighton pushed a commit that referenced this pull request Nov 13, 2023
Following up on #27877, we had a broken link in two places. This fixes the second.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants