fix(secretsmanager): RotateSchedule is not disabled when automaticallyAfter is 0

[go-to-k]

This PR fixes the bug that a RotateSchedule is not disabled when automaticallyAfter is 0.

Closes #27460.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[go-to-k]

Duration.days(0) should disable automatic rotation.

  /**
   * Specifies the number of days after the previous rotation before
   * Secrets Manager triggers the next automatic rotation.
   *
   * A value of zero will disable automatic rotation - `Duration.days(0)`.
   *
   * @default Duration.days(30)
   */
  readonly automaticallyAfter?: Duration;

aws-cdk/packages/aws-cdk-lib/aws-secretsmanager/lib/rotation-schedule.ts

Lines 36 to 44 in f9dcef2

	/**
	* Specifies the number of days after the previous rotation before
	* Secrets Manager triggers the next automatic rotation.
	*
	* A value of zero will disable automatic rotation - `Duration.days(0)`.
	*
	* @default Duration.days(30)
	*/
	readonly automaticallyAfter?: Duration;

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: aa26213
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[lpizzinidev]

Thanks 👍

[scanlonp]

I believe that the current behavior is intended (see discussion on issue #27460 (comment)). Using the 'magic' value of 0 on automaticallyAfter was designed to get around a limitation of being forced into the default rather than leaving it unset.

As of now, I do not think this change is necessary. There may still be a case for improving the doc string to be more descriptive of what the actual behavior is.

[go-to-k]

@scanlonp

OK, I will submit another PR for modifying the doc.