fix(pkglint): allow dependencies on L1 only modules #21208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
comcalvi
added
pr-linter/exempt-test
rix0rrr
reviewed
Jul 19, 2022
tools/@aws-cdk/pkglint/lib/rules.ts
Outdated
| if (maturity === 'cfn-only') { | ||
| return; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | ||
| const stability = require(`${dep}/package.json`).stability; |
There was a problem hiding this comment.
We should ignore stability.
maturity== how we feel about the reliability of the package.stability== the default stability of API elements in this package (i.o.w, setting this is just syntactic sugar over putting@stable,@experimentaletc in every docstring)
comcalvi
added
the
pr-linter/exempt-test
rix0rrr
approved these changes
Jul 22, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mackalex
pushed a commit
to mackalex/aws-cdk
that referenced
this pull request
Jul 30, 2022
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
Today, pkglint prevents any module from depending on any experimental module, regardless of its `maturity`. This PR considers `maturity` such that `cfn-only` modules can be taken as dependencies. While writing tests for this is possible, it would be out-of-scope for this PR. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, pkglint prevents any module from depending on any experimental module, regardless of its
maturity. This PR considersmaturitysuch thatcfn-onlymodules can be taken as dependencies. While writing tests for this is possible, it would be out-of-scope for this PR.All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license