feat(assertions): an initial version of the CDK 'assert' library, now experimentally available in all supported languages #14952
Conversation
|
|
peterwoodworth
added
the
@aws-cdk/assertions
nija-at
force-pushed
the
nija-at/assertv2
branch
from
dff0f30 to
29e0dda
Compare
nija-at
changed the title
nija-at
force-pushed
the
nija-at/assertv2
branch
from
2766055 to
c656b29
Compare
| } | ||
| } | ||
|
|
||
| function toTemplate(stack: Stack): any { |
There was a problem hiding this comment.
As commented in the RFC, I believe we may want to expose this method directly to support snapshot tests:
expect(Template.fromStack(stack)).toMatchSnapshot();There was a problem hiding this comment.
Let's add this in, as we need it.
There was a problem hiding this comment.
What do you mean "as we need it"? The use case is clear and almost every construct library I've written used snapshot tests to some degree. The current assert library as "SynthUtils" which offer this api, which implies "we already need it". No?
There was a problem hiding this comment.
I'll be migrating more construct libraries to use 'assertions'. This PR only migrates efs. I'll add it when I come across one.
Co-authored-by: Elad Ben-Israel <[email protected]>
| * Typically used, as part of unit tests, to validate that the rendered | ||
| * CloudFormation template has expected resources and properties. | ||
| */ | ||
| export class TemplateAssertions { |
There was a problem hiding this comment.
Slight preference for Assertions here (shorter name, easier to read and type). But I guess potato potato.
rix0rrr
changed the title
rix0rrr
changed the title
nija-at
changed the title
nija-at
force-pushed
the
nija-at/assertv2
branch
from
ac9763e to
67af532
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@Mergifyio refresh |
…w experimentally available in all supported languages (aws#14952) Announcing 'assertions', the next revision of the CDK assert module. This module is built via jsii and hence is available in all CDK supported languages. Motivation and design: https://github.com/aws/aws-cdk-rfcs/blob/master/text/0328-polyglot-assert.md
…w experimentally available in all supported languages (aws#14952) Announcing 'assertions', the next revision of the CDK assert module. This module is built via jsii and hence is available in all CDK supported languages. Motivation and design: https://github.com/aws/aws-cdk-rfcs/blob/master/text/0328-polyglot-assert.md
Announcing 'assertions', the next revision of the CDK assert
module. This module is built via jsii and hence is available in
all CDK supported languages.
Motivation and design: https://github.com/aws/aws-cdk-rfcs/blob/master/text/0328-polyglot-assert.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license