-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: permissions boundary not being applied to custom resource role #30179
Comments
Hi @adamtimmins , thanks for reaching out. It seems like what you are mentioning here is quite similar to the bug described here and this reasoning and further explanation might be helpful to understand why. Please feel free to reach out if its not helpful or different than what you are implying. |
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Hi, Could we please have this bug fixed? Our organization is requiring that we have permission boundaries implemented on all Roles that we create and there is currently no way to add a boundary to AWSCDKCfnUtilsProviderCustomResourceProviderRoleFE0EE867 as mentioned above. |
@adamtimmins , Could you please share the the complete repro code. I also see there is a closed issue similar to the custom role mentioned above - #22972 and many more (#13310) and previous attempts have been made for such similar issues like this PR - #14754. However this still seems like an issue so I am marking this as P1 for the appropriate traction. |
Hi Khurana,
I have added you to my repo so you can reproduce the bug. Please let me
know how it goes.
Cheers,
David
…On Wed, May 29, 2024 at 4:39 AM Shailja Khurana ***@***.***> wrote:
@adamtimmins <https://github.com/adamtimmins> , Could you please share
the the complete repro code.
I also see there is a closed issue similar to the custom role mentioned
above - #22972 <#22972> and previous
attempts have been made for such similar issues like this PR - #14754
<#14754>. However this still seems
like an issue so I am marking this as P1 for the appropriate traction.
—
Reply to this email directly, view it on GitHub
<#30179 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2L3GKCI2FASVSH5J4S2CDZETFNBAVCNFSM6AAAAABHUCKCV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVHA4DQMJXG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have attempted these workarounds but none of them seem to work. I have raised the issue and shared the code with AWS premium support and when I get a response I'll share it here. |
It is also possible to patch using the Aspect as follows given that the type of object for the role is a CfnResource and it has a node path (example using Custom Resource to delete S3 bucket objects):
|
Have you tried using this solution when deploying the stack via CDK Pipelines. I've tried using a custom aspect before but it didn't work. Also can you explain this line please |
@adamtimmins actually above was just an example of getting to the resource you want to "patch" with an Aspect (in this case I assign an IAM path to isolate the "app" workload from other workloads). But you could equally do this as well (as an example)...
As for your comment on CDK pipelines. Although having used CDK pipelines in the past I can't recall combining an Aspect like this with the pipelines. I don't see why it wouldn't work but then I haven't tried it. In the case of CDK pipelines I suspect that scope of the aspect is everything. As in: the CDK pipeline itself couldn't be subject to the permissions boundary as this would mean that it (and by it I mean the pipeline role) would be subject to the same "rules" (permissions boundary) as the stacks it's trying to deploy. Hence, you would probably - at a guess - just apply the Aspect to the "app stacks". If I ever get a chance to combine the two I will let you know of the outcome... Morten |
Hi Morten, I printed every node with an Aspect in my stack, however, AWSCDKCfnUtilsProviderCustomResourceProviderRoleFE0EE867 did not get printed even though it is a AWS::IAM::Role and appears in the Cloudformation template. This means this role is not part of the construct tree structure and cannot be referenced at all within CDK. It's similar to how CDKMetadata is a resource in the Cloudformation but is not in the node tree structure and cannot be referenced. David |
Appreciate your explanation here, just confirms what I suspect as well. I have already tried applying a custom aspect and an escape hatches to the stack as well as the CDK pipelines just to see if it makes a difference and nothing did.
This is exactly what I seeing as well. I'm printing all the node paths as well, and I'm not seeing |
@adamtimmins I ran into the same issue yesterday, even posted a comment here but then I deleted it as I found the issue. I was applying Aspects to the scope of the Not sure if this applies in your case but make sure you're applying Aspects at the correct level. |
Hi David, The Aspect was "attached" at stack level with Morten |
@imduchy when I print all the node paths from the stack level I'm still not seeing the ID for the role. The same as well when I print all the node paths from the
@mjvirt thanks for the explanation but I'm still not seeing node path on the stack level. |
I've managed to isolate where exactly the role is being created.
From my example this is when I reference
If I replace the
I tried looking around for what this Lambda does but I can't find anything. It's completely without context of the CDK app hence why adding a permission boundary with an custom aspect or an escape hatch won't work. I'm not sure of a work around since the only way to make the custom resource work is to add interface ID's manually which is not really the point of my use case. |
Hi khushail, Just wondering if you were able to reproduce the bug with my repo code? Cheers, David |
Hi @dliu864 , apologies for the delay in getting back. The code is in java and I am not that much familiar with it. Although I have been trying to repro it using typescript in my account. I have marked the issue as P1 for the appropriate traction by the team as it has been reported by many customers. |
I found some Typescript CDK code which reproduces the same bug if that helps:
Or this ghost-role (AWSCDKCfnUtilsProviderCustomResourceProviderRoleFE0EE867) is not amendable... Error:
Stack:
Originally posted by @nocquidant in #22972 (comment) |
Had a back and forth with AWS premium support and was recommended the following solution, which worked for us (thanks Greg!). The solution for us was to use First thing to do is synth your application as normal and take a note of the path of all the roles in the stack. You can find the path under Then at the top of the stack place your iam.Role.customize_roles(
self,
prevent_synthesis=True,
use_precreated_roles={
"CdkPipelines/ToolingDeployment/tooling-ApiGateway/AWSCDKCfnUtilsProviderCustomResourceProvider/Role": "custom_resource_role_name"
],
"CdkPipelines/ToolingDeployment/tooling-ApiGateway/AWS679f53fac002430cb0da5b7982bd2287/ServiceRole": "custom_resource_role_name"
],
},
) It's important to set Hope this helps! |
I can confirm the same behaviour - CDK Aspects won't affect these roles. However, the roles are removed if I remove references to other resources from the [EDIT: 06.10.2024] It seems I made it work by using the VPC endpoint's security group's ID instead of the VPC endpoint's ENI's IDs. For some reason, this works perfectly fine and doesn't create the
I think this is a better solution than using Still, it would be great to understand why is the |
Describe the bug
I'm deploying a stack through CDK pipelines and have a permissions boundary configured within
cdk.json
. Every role is being configured app wide with the permissions boundary apart from one which seems to be created by CDK itself for myAwsCustomResource
.Expected Behavior
I expect the permissions boundary to be applied the CDK application app wide and not miss any roles deployed by the CDK application
Current Behavior
The CDK created role is failing to add the permissions boundary to the application.
Reproduction Steps
CDK pipelines is being deployed using bootstrapped roles with a custom qualifier and where the permission boundary is required.
AwsCustomResource
The role in question not being provided the permission boundary
AWSCDKCfnUtilsProviderCustomResourceProviderRoleFE0EE867
The
cdk.json
configPossible Solution
No response
Additional Information/Context
I have tried adding the permission boundary to the stack itself, as well as the custom resource itself following the documentation here: https://docs.aws.amazon.com/cdk/api/v1/python/aws_cdk.aws_iam/README.html#permissions-boundaries
I have also tried creating a custom aspect to add the stack and the stage but none of these worked either:
#3242 (comment)
CDK CLI Version
2.141.0
Framework Version
No response
Node.js Version
v22.1.0
OS
Sonoma 14.2.1
Language
Python
Language Version
3.12.3
Other information
No response
The text was updated successfully, but these errors were encountered: