-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stepfunctions-tasks: mwaa service generates wrong action in role policy #28081
Labels
@aws-cdk/aws-stepfunctions-tasks
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Comments
tam0ri
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 21, 2023
Thank you for your PR! |
pahud
added
p2
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 21, 2023
mergify bot
pushed a commit
that referenced
this issue
Dec 5, 2023
… policy (#28082) When we use CallAwsService for Step Functions task, CDK generates IAM policy to grant permission regarding the API call. However, if we specify `mwaa` as service in CallAwsService, CDK generates wrong policy statement such as `mwaa:listEnvironments`. Correct service prefix for MWAA is `airflow`. https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonmanagedworkflowsforapacheairflow.html > Amazon Managed Workflows for Apache Airflow (service prefix: airflow) provides the following service-specific resources, actions, and condition context keys for use in IAM permission policies. This PR solves the issue by adding `mwaa` into iamServiceMap. This is similar with #27623. Closes #28081 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
chenjane-dev
pushed a commit
to chenjane-dev/aws-cdk
that referenced
this issue
Dec 5, 2023
… policy (aws#28082) When we use CallAwsService for Step Functions task, CDK generates IAM policy to grant permission regarding the API call. However, if we specify `mwaa` as service in CallAwsService, CDK generates wrong policy statement such as `mwaa:listEnvironments`. Correct service prefix for MWAA is `airflow`. https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonmanagedworkflowsforapacheairflow.html > Amazon Managed Workflows for Apache Airflow (service prefix: airflow) provides the following service-specific resources, actions, and condition context keys for use in IAM permission policies. This PR solves the issue by adding `mwaa` into iamServiceMap. This is similar with aws#27623. Closes aws#28081 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-stepfunctions-tasks
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Describe the bug
Following code is properly creates a step in Step Functions
However, it creates wrong statement in the role policy.
Correct service prefix for MWAA is
airflow
.https://docs.aws.amazon.com/service-authorization/latest/reference/list_amazonmanagedworkflowsforapacheairflow.html
This issue is similar with #27573.
Expected Behavior
Action should be
airflow:listEnvironments
Current Behavior
Action is
mwaa:listEnvironments
Reproduction Steps
Sample code for reproduction is below:
Possible Solution
Adding
mwaa
into iamServiceMap. I'll submit PR later.aws-cdk/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/aws-sdk/call-aws-service.ts
Lines 92 to 95 in 25ee8ef
Additional Information/Context
No response
CDK CLI Version
v2.110.0
Framework Version
No response
Node.js Version
v18.17.1
OS
Linux
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: