-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-ec2: duplicate InterfaceVpcEndpointAwsService for SES, EMAIL_SMTP #27662
Labels
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
3dbrows
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 24, 2023
github-actions
bot
added
the
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
label
Oct 24, 2023
Thank you for your report. I think two same endpoints are added accidentally. |
Thanks for reporting this @3dbrows . |
khushail
added
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 24, 2023
mergify bot
pushed a commit
that referenced
this issue
Nov 9, 2023
Deprecates endpoints with the same name and reorganizes properties alphabetically. Closes #27662. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
mikewrighton
pushed a commit
that referenced
this issue
Nov 13, 2023
Deprecates endpoints with the same name and reorganizes properties alphabetically. Closes #27662. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Describe the bug
The definition of
InterfaceVpcEndpointAwsService
contains definitions for SES and EMAIL_SMTP, but these both create services with the nameemail-smtp[.suffix]
.It is not clear what, if any, functional difference there is between these two.
Expected Behavior
Either of the following:
email-smtp
Current Behavior
Both are available, which means if in confusion or hedging your bets you try to use both, you cannot because CloudFormation will return:
Reproduction Steps
Possible Solution
Document the reason for the presence of both, or, deprecate one of them.
Additional Information/Context
As a user of SES, I would like to be clear if the interface endpoints provided give access to the SMTP host, the SES REST API, or both. It appears to be the former, but one might expect the
SES
interface endpoint to provide access to the API and theEMAIL_SMTP
interface endpoint to provide access to the SMTP host (e.g.email-smtp.eu-west-1.amazonaws.com
).CDK CLI Version
2.83.1 (build 006b542)
Framework Version
No response
Node.js Version
18.17.1
OS
Linux
Language
TypeScript
Language Version
No response
Other information
Previous commits to add the existing options are here and here.
Both commits were released in version
2.47.0
. It feels likely that the release should have contained only one entry. I suspectEMAIL_SMTP
makes the most sense because it explicitly refers to the SMTP host, I think.@watany-dev and @clueleaf might have additional context here.
The text was updated successfully, but these errors were encountered: