chore(route53): migrate existing record set handler (#28053)

This PR moves the delete existing record set handler from aws-cdk-lib to our new centralized location for custom resource handlers in the [@aws-cdk](https://github.com/aws-cdk) package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Nov 20, 2023 · 8fcc210 · 8fcc210
1 parent 2c21ea0
commit 8fcc210
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 66 deletions.
diff --git a/....snapshot/asset.482643dcf7106ecdc7f4ff9aefba13d1e5c7265377e6c6b9c77245f2bc55f6ef/index.js b/....snapshot/asset.482643dcf7106ecdc7f4ff9aefba13d1e5c7265377e6c6b9c77245f2bc55f6ef/index.js
diff --git a/...7e6c6b9c77245f2bc55f6ef/__entrypoint__.js → ...8a3fc902354155a2b0b00c5/__entrypoint__.js b/...7e6c6b9c77245f2bc55f6ef/__entrypoint__.js → ...8a3fc902354155a2b0b00c5/__entrypoint__.js
diff --git a/....snapshot/asset.a4d4a9308995dd99b8a8a3089e4f2087a577a6d3f8a3fc902354155a2b0b00c5/index.js b/....snapshot/asset.a4d4a9308995dd99b8a8a3089e4f2087a577a6d3f8a3fc902354155a2b0b00c5/index.js
diff --git a/...-existing-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.assets.json b/...-existing-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.assets.json
diff --git a/...xisting-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.template.json b/...xisting-record-set.js.snapshot/cdk-route53-integ-delete-existing-record-set.template.json
@@ -151,7 +151,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
      },
-     "S3Key": "482643dcf7106ecdc7f4ff9aefba13d1e5c7265377e6c6b9c77245f2bc55f6ef.zip"
+     "S3Key": "a4d4a9308995dd99b8a8a3089e4f2087a577a6d3f8a3fc902354155a2b0b00c5.zip"
     },
     "Timeout": 900,
     "MemorySize": 128,

diff --git a/...rk-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/manifest.json b/...rk-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/manifest.json
diff --git a/...mework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/tree.json b/...mework-integ/test/aws-route53/test/integ.delete-existing-record-set.js.snapshot/tree.json
diff --git a/...lete-existing-record-set-handler/index.ts → ...lete-existing-record-set-handler/index.ts b/...lete-existing-record-set-handler/index.ts → ...lete-existing-record-set-handler/index.ts
diff --git a/...elete-existing-record-set-handler.test.ts → ...elete-existing-record-set-handler.test.ts b/...elete-existing-record-set-handler.test.ts → ...elete-existing-record-set-handler.test.ts
@@ -1,4 +1,4 @@
-import { handler } from '../lib/delete-existing-record-set-handler';
+import { handler } from '../../lib/aws-route53/delete-existing-record-set-handler';
 
 const mockListResourceRecordSetsResponse = jest.fn();
 const mockChangeResourceRecordSetsResponse = jest.fn();

diff --git a/packages/aws-cdk-lib/aws-route53/lib/delete-existing-record-set-handler/.is_custom_resource b/packages/aws-cdk-lib/aws-route53/lib/delete-existing-record-set-handler/.is_custom_resource
diff --git a/packages/aws-cdk-lib/aws-route53/lib/record-set.ts b/packages/aws-cdk-lib/aws-route53/lib/record-set.ts
@@ -269,7 +269,7 @@ export class RecordSet extends Resource implements IRecordSet {
     if (props.deleteExisting) {
       // Delete existing record before creating the new one
       const provider = CustomResourceProvider.getOrCreateProvider(this, DELETE_EXISTING_RECORD_SET_RESOURCE_TYPE, {
-        codeDirectory: path.join(__dirname, 'delete-existing-record-set-handler'),
+        codeDirectory: path.join(__dirname, '..', '..', 'custom-resource-handlers', 'dist', 'aws-route53', 'delete-existing-record-set-handler'),
         runtime: CustomResourceProviderRuntime.NODEJS_18_X,
         policyStatements: [{ // IAM permissions for all providers
           Effect: 'Allow',