Skip to content

Commit

Permalink
fix(event-targets): ecsTask uses invalid task definition arn in policy (
Browse files Browse the repository at this point in the history
#31615)

### Issue # (if applicable)

Closes #30390 . 

### Reason for this change

This is extending a closed PR #30484 by @jwoehrle . I couldn't update that PR so I am creating this new one.

Reason for this change is due to a AWS ECS campaign where they are asking customers to add task definition revision number (or wildcard as the revision number) to IAM policies.

### Description of changes

When adding permission to the Events Role to allow it to use the task definition, check if the task definition arn has a revision number, if yes, do nothing, if not, add the wildcard `*`. This is only done when the task definition arn is not using any token.

### Description of how you validated changes

Unit tests and Integ tests are added.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
samson-keung authored Oct 7, 2024
1 parent 857bdc7 commit 4ada3ea
Show file tree
Hide file tree
Showing 13 changed files with 2,783 additions and 1 deletion.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 4ada3ea

Please sign in to comment.