Deploy a multiarch image #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BennettJames
force-pushed
the
multiarch-image-redux
branch
from
5913eef to
ab77714
Compare
joesbigidea
reviewed
May 26, 2023
| docker pull ${{ secrets.BETA_AWS_ACCOUNT }}.dkr.ecr.us-west-2.amazonaws.com/amazon/appmesh-controller:${{ github.event.inputs.tag }}-linux_arm64 | ||
| - name: Configure AWS Credentials (prod) | ||
| uses: aws-actions/configure-aws-credentials@v1 | ||
| src_host: "${{ secrets.BETA_AWS_ACCOUNT }}.dkr.ecr.us-west-2.amazonaws.com" |
There was a problem hiding this comment.
You changed the beta-release workflow to use secrets.CI_AWS_ACCOUNT but here you're still using secrets.BETA_AWS_ACCOUNT. I could use some context to understand what's going on between these.
There was a problem hiding this comment.
Standardized on BETA - these are the same values now; this patch just had it's roots back when CI was a distinct value that was used for beta image building and testing.
.github/workflows/beta-release.yaml
Outdated
|
|
||
| push-images: | ||
| name: Build And Push Images | ||
| runs-on: ubuntu-22.04 | ||
| needs: [ integration-test ] |
There was a problem hiding this comment.
how are we enforcing integration-tests before beta push and eventually prod push?
There was a problem hiding this comment.
Reverted. There are some process changes I want to make around testing for a release, but this isn't the right place to start them.
BennettJames
force-pushed
the
multiarch-image-redux
branch
from
ab77714 to
fb0b384
Compare
Previously, the "main" image was always an amd64 image, and there was a secondary arm64 image that could be used with an explicit tag. This makes the amd64 image also have an explicit tag, and replaces the normal tagged image with a manifest file that will correctly route to the appropriate architecture.
BennettJames
force-pushed
the
multiarch-image-redux
branch
from
fb0b384 to
657dbc9
Compare
joesbigidea
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Deploy a multiarch image
Previously, the "main" image was always an amd64 image, and there was
a secondary arm64 image that could be used with an explicit tag. This
makes the amd64 image also have an explicit tag, and replaces the normal
tagged image with a manifest file that will correctly route to the appropriate
architecture.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.