Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publishing missing datapoints in UserTriggerDecisionEvent telemetry events #217

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

brandonskiser
Copy link
Contributor

Description of changes:

  • Add number_of_recommendations and accepted_character_count datapoints to the UserTriggerDecisionEvent metric.
  • Set generated_line to 1 as per an internal request. 1 is considered a better default than 0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brandonskiser brandonskiser requested a review from a team as a code owner December 6, 2024 22:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 12.28%. Comparing base (83e218c) to head (4073a32).

Files with missing lines Patch % Lines
crates/figterm/src/inline/mod.rs 0.00% 5 Missing ⚠️
crates/fig_telemetry/src/lib.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   12.27%   12.28%   +0.01%     
==========================================
  Files        2246     2246              
  Lines      191054   191068      +14     
  Branches   174971   174985      +14     
==========================================
+ Hits        23448    23470      +22     
+ Misses     166409   166399      -10     
- Partials     1197     1199       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 changed the title Fix publishing missing datapoints in UserTriggerDecisionEvent telemetry events fix: publishing missing datapoints in UserTriggerDecisionEvent telemetry events Dec 7, 2024
@grant0417 grant0417 merged commit 23044f6 into main Dec 7, 2024
20 checks passed
@grant0417 grant0417 deleted the bskiser/fix-telemetry branch December 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants