Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): Change the project.toml to restrict Python 3.10 version #1412

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #1404

Summary

Changes

Added a restriction in project.toml to only accept Python versions higher than 3.6.2 and lower than 3.10.

@heitorlessa @rubenfonseca should we add a paragraph to ensure that contributors/users are aware of this restriction?

User experience

Before: User could install the Lambda Powertools project even using Python 3.10.
image
image

After: User must use python lower than 3.10
image
image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 3, 2022 17:18
@leandrodamascena leandrodamascena requested review from mploski and removed request for a team August 3, 2022 17:18
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Aug 3, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2022
@github-actions github-actions bot added the internal Maintenance changes label Aug 5, 2022
@heitorlessa heitorlessa self-assigned this Aug 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1412 (2606596) into develop (144e9cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1412   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files          119      119           
  Lines         5456     5456           
  Branches       624      624           
========================================
  Hits          5450     5450           
  Misses           2        2           
  Partials         4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@heitorlessa
Copy link
Contributor

As discussed in the issue, closing as this will impact customers using OCI images.

@heitorlessa heitorlessa closed this Sep 1, 2022
@leandrodamascena leandrodamascena deleted the chore/pypi-python-version branch September 6, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants