chore(ci): define github labels as code #731
Open
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
615a118 to
51fd319
Compare
darioush
previously approved these changes
Jan 3, 2025
qdm12
commented
Jan 3, 2025
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
188ec04 to
d949aa3
Compare
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
d949aa3 to
de8b544
Compare
darioush
approved these changes
Jan 7, 2025
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
de8b544 to
fc9d106
Compare
meaghanfitzgerald
approved these changes
Jan 8, 2025
Comment on lines
+1
to
+6
| - name: "after coreth x subnet-evm" | ||
| color: "98E19D" | ||
| description: "To be done after merging the coreth and subnet-evm codebases" | ||
| - name: "after libevm" | ||
| color: "98E19D" | ||
| description: "To be done only after using libevm for good" |
There was a problem hiding this comment.
[no action required] these labels share the same color
There was a problem hiding this comment.
Indeed but:
- already the case, we may change in a subsequent PR modifying this file
- grouping similar labels (after xyz) with the same color is useful in my opinion 😉 Especially finding a distinguishable color for each label is rather difficult as soon as you have around 10 labels 😓
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
3 times, most recently
from
7c4a759 to
cfc3742
Compare
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
cfc3742 to
b95e6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allow to track in source control the Github labels, and to easily migrate Github labels (i.e. renames).
How this works
New Github workflow
.github/workflows/labels.ymlusinggithub/labels.ymlas a source for the labels. All the label data was extracted from this API call to keep it the exact same.Removed useless labels according to Darioush 😉
How this was tested
Dry run of labeler job on this PR
Need to be documented?
No
Need to update RELEASES.md?
No