Add chromium container #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Dec 21, 2018
| * Test containers start a docker with Ryuk. Ryuk needs to mount the docker socket, and this is forbidden in Bitbucket pipelines. | ||
| * Ryuk isn't a critical feature. It makes after test docker container cleanup more robust. | ||
| * This class is a hack to disable the feature. | ||
| * Sorry for the hack, but I neither understand how to fix Ryuk problems, neither want to fork and release forked test-containers. |
There was a problem hiding this comment.
Soon, we will make it possible to disable Ryuk if you env allows it :) See testcontainers/testcontainers-java#1023
Good that you have a workaround meanwhile!
There was a problem hiding this comment.
Great to hear that. Disabling Ryuk will still be a workaround, but more straightforward and managed on the product's side. Are there any plans to make Ryuk work on BB pipelines?
There was a problem hiding this comment.
Well, it used to work but then there was some change on BB side and it got broken.
We track the current state of BitBucket here:
testcontainers/testcontainers-java#700 (comment)
There was a problem hiding this comment.
wyrzyk
force-pushed
the
add-chromium-container
branch
from
4e0376e to
b501885
Compare
dagguh
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.