feat: added some additional linting rules to autofix prettier related… #59
Conversation
… issues, added filesystem based upload download API
…rformance into issue-30-issue-24
|
re: feedback I think you're right if we go with this pseudo-selected pattern the icons should be inverted. I've amended that. The accessibility change is a bit meh, I'm not sure it was necessary to begin with in the context of this tool (there are deeper issues in that sense and it's a bit of a rabbit hole we'd rather avoid). I've amended the Hope that works 👍 |
| @@ -9,6 +9,8 @@ export type MachineEvents = | |||
| | { type: 'FINISH'; results: TaskGroupResult[] } | |||
| | { type: 'PIN' } | |||
| | { type: 'UNPIN' } | |||
| | { type: 'SAVE' } | |||
There was a problem hiding this comment.
Can we rename this event to SAVE_TO_FILE so that is nicely paired with LOAD_FROM_FILE ? :D
| }; | ||
| }), | ||
| }, | ||
| LOAD_FROM_FILE: { |
There was a problem hiding this comment.
We are effectively re-implementing the PIN event right? Maybe the PIN event could include a message value so that we could simply reuse the PIN event rather than created another event just so we can have a different message
There was a problem hiding this comment.
Open to your thoughts though
There was a problem hiding this comment.
This may have been an artefact of how I was wrapping the way the state machine worked and so it was seperated. But yeah more or less, that would make sense ya.
PR adds functionality to partially address #30 and #24
I'm sure this can be done better.