Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Slack panel for projects without workspace mapping #304

Open
annapieper opened this issue Aug 11, 2023 · 6 comments
Open

Hide Slack panel for projects without workspace mapping #304

annapieper opened this issue Aug 11, 2023 · 6 comments
Labels
enhancement New feature or request jira

Comments

@annapieper
Copy link

The Slack Panel in the issue view is shown even when the current project is not connected to a Slack channel.

The ideal solution would be to implement an Opt-In configuration instead of Opt-out for the panel like it is now the case. For big instances (e.g. ~2000 projects with only a few connected to Slack) it would be better this way because with the creation of a new project the admin would only need to configure it if the Slack panel should NOT be hidden and otherwise it would be hidden by default if no connection is configured.

The lightweight solution for the problem is to implement an additional condition when the Slack Panel should be shown: So even if it is not configured as hidden (neither globally nor locally in the project) the panel should not show up in the issue view if the current project is not mapped to a Slack workspace in the global Slack configuration.

@annapieper
Copy link
Author

I'm currently implementing this issue.

annapieper added a commit to annapieper/atlassian-slack-integration-server that referenced this issue Aug 30, 2023
…t if a slack workspace is configured for current project
@mvlasovatl
Copy link
Contributor

I have conflicting feelings about the proposed change. Even if a project doesn't have a subscription, Slack panel on that project issue view may still be useful to see issue mentions or create/view a dedicated channel.
Replacing current panel visibility logic with an opposite one would be a disrupting change, that would break expectations of existing users that are already used to current behaviour.
Adding a new option to project-level Advanced Setting popup to show issue panel for a particular project regardless of panels being hidden globally may lead to user confusion as well. There would 3 levels of overriding for that option: global, hide per project, show per project.

Taking into account the mentioned complications, the change seems to be a good candidate for customer specific build from a fork. For wider audience it wouldn't be that useful.

@mvlasovatl mvlasovatl added enhancement New feature or request jira labels Oct 4, 2023
@annapieper
Copy link
Author

@mvlasovatl
I understand.
Would it be a better solution for you if we would add a global option e.g. "Hide Slack panel for projects with no channel configured" which is disabled per default so that it works like now and if you enable the option then the functionality described in this issue will take effect?

@annapieper
Copy link
Author

@mvlasovatl Can you already say if you would take my suggestion into consideration?

@mvlasovatl
Copy link
Contributor

This is being discussed within the team. Generally we accept all bug fixes, but new features may increase maintenance cost, so in this case the decision is made on per-feature basis.

@mvlasovatl
Copy link
Contributor

The team decided to put new feature acceptance on pause for now to minimize maintenance cost. We may reconsider it later next year when we are less busy with other important projects.
For now this comment may be used as a place for voting for the feature with 👍 reactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira
Projects
None yet
Development

No branches or pull requests

2 participants