-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving issue number #1080 #1081
Conversation
…sole. It was solved by adding install.sh which is a script to hide the deprecated output and modified validate-examples.yml by giving cmd to run install.sh this solve the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
We require all PRs to follow Conventional Commits specification.
|
Quality Gate passedIssues Measures |
@maskedwolf4 would you mind sharing what are you really trying to achieve here? Hidding warnings? What is the reason about? |
Actually it's my first contribution I'm not that much experienced and was bit confused |
When I used the npm install it showed me all the warnings of deprecated versions. So better show msg of showing installation completed rather than showing such output And also I have some installation problems |
Warnings should be always there; we should rather work on fixing those warnings (updating deprecated packages for example) rather than hiding them. Hiding them seems like sweeping under the rug. Would you mind sharing what are the exact commands you are following, a link to the exact asyncapi website page they are shown, and the issues you are facing? |
I have shared the SS of the commands and problems I'm facing. The commands I used are: Can you suggest what should I do to solve this bug and essential tips to contribute so that I don't do such mistakes again |
I can't see any bug happening in that execution. The error says the operation got aborted. Aren't you aborting the operation manually? |
Actually it's my first contribution I'm not that much experienced and was bit confused No |
This PR is not addressing asyncapi/website#3522 The problem is website-related. @maskedwolf4 if you really wanna help open source maintainers, you need first to read the contribution guide, understand requirements, and never start with PR in a project you are unfamiliar with. Always clarify first the issue, what the problem is, and how it can be fixed. To be honest, open source or regular job on closed source - first, always clarify the scope of the work, and then do the work. The linked issue is transferred to ✌🏼 |
Sure |
see you in asyncapi/website#3522 |
Solving issue asyncapi/website#3522
"The official website's command to try is not even working in the first place"
The terminal was showing the msg on running cmd from website like:
npm warn deprecated [email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Use your platform's native DOMException instead
npm warn deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Use your platform's native performance.now() and performance.timeOrigin.
npm warn deprecated @asyncapi/[email protected]: Hooks are now part of generator repository and also out of the box integrated with the generator, so no need to set it as dependency any more: https://github.com/asyncapi/generator/releases/tag/%40asyncapi%2Fgenerator%402.5.0
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated @oclif/[email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated @hyperjump/[email protected]: This package was rolled into @hyperjump/json-schema as of v1.0.0
Code Changes Done
-Added install.sh script to remove deprecating messages
-Modified run command in validate-examples.yml giving cmd to run install.sh
-The terminal will show msg "Async API installed successfully"