-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up registry doctest #567
Conversation
This is now about 20 seconds where I sit... ...provided we don't happen to hit broken obscore services. My take on that would be to throw not run the global obscore things any more as soon as the global dataset discovery stuff is merged -- this does all that a lot better, with proper timeout and possibly other services as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise looks good.
Thanks!
|
||
.. doctest:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this directive, code with >>>
are picked up for doctesting
.. doctest:: |
while checking this locally, I discovered some weird behaviour/bug of the tests, I'll open a separate issue for that as the behaviour is present on |
On Fri, Jun 28, 2024 at 09:58:34AM -0700, Brigitta Sipőcz wrote:
@bsipocz approved this pull request.
Minor comment, otherwise looks good.
Thanks!
> +
+.. doctest::
no need for this directive, code with `>>>` are picked up for doctesting
```suggestion
```
How bad is the spurious doctest::? I'm asking because to simplify
the logic of my doctest profiler,
https://blog.g-vo.org/watch-sphinx-doctests.html, I'm only picking up
python lines from RST blocks with doctest directives.
I *can* loosen this up, but if the occasional explicit but
unnecessary directive doesn't bother anyone badly, I'd like it better
if were were explicit.
[And yes, it would be preferable if I used whatever logic sphinx uses
to pick up the tests for the profiler, but I figured I'd spend a lot
more time on locating that than I wanted to spend on this
tooling-for-tooling thing].
|
We don't use sphinx for picking up doctests and its plumbing is somewhat different than the pytest ecosystem and plugins we use (e.g. some sphinx doctest directives are known to not work with pytest/pytest-doctestplus and similarly, some doctestplus things that we rely on are known not working with sphinx.). So, while most things may work without issues, I wouldn't be surprised if you see doctest failures in CI even if they pass with the sphinx system locally. So, having this one |
This is using other constraints and services in order to transfer less data and perhaps have faster queries.